Skip to content

Commit 4c98e94

Browse files
committed
security: highlight phab accounts; recommend phab for nominations
This commit contains two mildly separate concepts. First, sending out reviews for things like this is a bit of a complicated endeavor, since the reviewer list is relatively long, and I generally rely on prior CLs in this area to find an authoritative list. Life's quite a bit easier if phab usernames are readily available on the doc. So part 1 is making those available. Second, it seems to me that, at the moment, Phabricator makes the most sense for membership changes (incl. security group nominations). My reasoning for this is detailed in the diff, and to some extent in comment #1 of this bug <https://bugs.chromium.org/p/llvm/issues/detail?id=12#c1>. This change adds prose to recommend the use of Phabricator for nominations as a result. Differential Revision: https://reviews.llvm.org/D106917
1 parent 2d0ba5e commit 4c98e94

1 file changed

Lines changed: 21 additions & 19 deletions

File tree

llvm/docs/Security.rst

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -31,24 +31,24 @@ Group Composition
3131
Security Group Members
3232
----------------------
3333

34-
The members of the group represent a wide cross-section of the community, and meet the criteria for inclusion below.
35-
36-
* Ahmed Bougacha (Apple)
37-
* Artur Pilipenko (Azul Systems Inc)
38-
* Dimitry Andric (individual; FreeBSD)
39-
* Ed Maste (individual; FreeBSD)
40-
* George Burgess IV (Google)
41-
* Josh Eads (Sony)
42-
* Kate McInnes (Apple)
43-
* Kristof Beyls (ARM)
44-
* Matthew Riley (Google)
45-
* Oliver Hunt (Apple)
46-
* Paul Robinson (Sony)
47-
* Peter Smith (ARM)
48-
* Pietro Albini (individual; Rust)
49-
* Serge Guelton (RedHat)
50-
* Shayne Hiet-Block (Microsoft)
51-
* Steve Klabnik (Oxide Computer Company; Rust)
34+
The members of the group represent a wide cross-section of the community, and meet the criteria for inclusion below. The list is in the format `* ${full_name} (${affiliation}) [${phabricator_username}]`. If a phabricator username for an individual isn't available, the brackets will be empty.
35+
36+
* Ahmed Bougacha (Apple) [ab]
37+
* Artur Pilipenko (Azul Systems Inc) [apilipenko]
38+
* Dimitry Andric (individual; FreeBSD) [dim]
39+
* Ed Maste (individual; FreeBSD) [emaste]
40+
* George Burgess IV (Google) [george.burgess.iv]
41+
* Josh Eads (Sony) []
42+
* Kate McInnes (Apple) []
43+
* Kristof Beyls (ARM) [kristof.beyls]
44+
* Matthew Riley (Google) [mattdr]
45+
* Oliver Hunt (Apple) [ojhunt]
46+
* Paul Robinson (Sony) [probinson]
47+
* Peter Smith (ARM) [peter.smith]
48+
* Pietro Albini (individual; Rust) [pietroalbini]
49+
* Serge Guelton (RedHat) [serge-sans-paille]
50+
* Shayne Hiet-Block (Microsoft) [Shayne]
51+
* Steve Klabnik (Oxide Computer Company; Rust) [steveklabnik]
5252

5353
Criteria
5454
--------
@@ -85,8 +85,9 @@ Nomination process
8585

8686
Anyone who feels they meet these criteria can nominate themselves, or may be nominated by a third party such as an existing LLVM Security Group member. The nomination should state whether the nominee is nominated as an individual, researcher, or as a vendor contact. It should clearly describe the grounds for nomination.
8787

88-
*FUTURE*: where nomination occurs (mailing list, GitHub, etc), can be decided later. See `Discussion Medium`_ below.
88+
For the moment, nominations are generally proposed, discussed, and voted on using Phabricator. An `example nomination is available here`_. The use of Phabricator helps keep membership discussions open, transparent, and easily accessible to LLVM developers in many ways. If, for any reason, a fully-world-readable nomination seems inappropriate, you may `open a new issue`_, and a discussion can be had about the best way to approach nomination, given the constraints that individuals are under.
8989

90+
Our recommended method of nomination may change as our `Discussion Medium`_ story evolves over time.
9091

9192
Choosing new members
9293
--------------------
@@ -226,3 +227,4 @@ The parts of the LLVM Project which are currently treated as non-security sensit
226227
.. _GitHub security: https://help.github.com/en/articles/about-maintainer-security-advisories
227228
.. _llvm-dev mailing list: https://lists.llvm.org/mailman/listinfo/llvm-dev
228229
.. _MITRE: https://cve.mitre.org
230+
.. _example nomination is available here: https://reviews.llvm.org/D99232

0 commit comments

Comments
 (0)