Skip to content

zip: update CreateHeaderRaw to handle zip64 fields. - #266

Merged
klauspost merged 1 commit into
klauspost:masterfrom
saracen:master
Jun 7, 2020
Merged

klauspost merged 1 commit into
klauspost:masterfrom
saracen:master

Conversation

@saracen

@saracen saracen commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

This adds the zip64 field handling identical to fileWriter.Close.

Without this, it is far easier to create an invalid ZIP file. This provides convenience for when you only want to set the compressed data length and CRC32 fields after using zip.FileInfoHeader, rather than handle multiple fields manually.

@klauspost klauspost left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klauspost

Copy link
Copy Markdown
Owner

Thanks for the contribution.

@klauspost
klauspost merged commit 01fb757 into klauspost:master Jun 7, 2020
@saracen

saracen commented Jun 7, 2020

Copy link
Copy Markdown
Contributor Author

@klauspost Thank you for implementing the CreateHeaderRaw proposal 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants