[WIP] Test several pull requests - #27191
Draft
MarkEWaite wants to merge 232 commits into
Draft
Conversation
move the controls to launch or mark offline to the main app-bar so it is available on each subpage
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
From Jenkins pom release: * https://github.com/jenkinsci/pom/releases/tag/2.1389.veca_379b_b_e95c
From Jenkins pom release: * https://github.com/jenkinsci/pom/releases/tag/2.1389.veca_379b_b_e95c
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…cessor-path', 'fix-26919-touch-doubletap', 'fix-26920-combobox-flash', 'fix-context-menu-post-notification', 'fix-global-search-job-name-display-name', 'fix/14784-limit-rss-changelog', 'fix/console-model-link-hover', 'fix/jenkins-75310-log-recorder-level', 'fix/quotedstringtokenizer-quote-javadoc-contract', 'fix/sortable-date-12am-midnight', 'individual-scrollers', 'issue/21047', 'jnowjack-abort-instead-of-fail' and 'login-page-password-ux' into Aardvark-Octopus
…ove-view-read', 'renovate/com.github.eirslett-frontend-maven-plugin-2.x', 'renovate/com.puppycrawl.tools-checkstyle-13.x', 'renovate/globals-17.x', 'renovate/lock-file-maintenance', 'renovate/major-stapler.version', 'renovate/net.java.sezpoz-sezpoz-1.x', 'renovate/node-24.x', 'renovate/org.jenkins-ci-jenkins-2.x', 'renovate/org.jenkins-ci.plugins-matrix-project-905.x' and 'renovate/org.xmlunit-xmlunit-bom-2.x' into Aardvark-Octopus
Contributor
There was a problem hiding this comment.
Pull request overview
This WIP PR aggregates a large set of changes across Jenkins core, WAR resources, frontend assets, tests, and build tooling, combining multiple independent pull requests into a single branch for validation.
Changes:
- Update UI/UX across multiple pages (agent pages, login/sign-up password controls, side panel/layout styling, dropdown interactions, notifications).
- Adjust security/permissions and API behavior (View permission model updates,
/pluginManager/api/jsonexport visibility, sanitization of update-site plugin excerpts). - Update build/test/tooling configuration (annotation processing configuration, core-libs bundling helpers, dependency bumps, SpotBugs exclusions, docs).
Reviewed changes
Copilot reviewed 219 out of 230 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| websocket/spi/pom.xml | Disable unnecessary annotation processing in SPI module |
| websocket/jetty12-ee9/pom.xml | Configure annotation processors for Jetty WebSocket module |
| webpack.config.js | Add sign-in page bundle entrypoint |
| war/src/main/webapp/scripts/sortable.js | Fix 12 AM sorting in date parser |
| war/src/main/webapp/scripts/hudson-behavior.js | Improve AutoScroller viewport detection logic |
| war/src/main/resources/images/symbols/eye-outline.svg | Add “eye” icon for password toggle |
| war/src/main/resources/images/symbols/caps-lock.svg | Add “caps lock” indicator icon |
| war/extract-core-lib-artifact-ids.groovy | Derive core-lib artifact IDs/excludes from jar properties |
| test/src/test/resources/jenkins/install/LoadDetachedPluginsTest/upgradeFromJenkins2/jenkins.install.InstallUtil.lastExecVersion | Update detached-plugin upgrade fixture |
| test/src/test/resources/hudson/classicpluginstrategydisableddep/test-resource | Add shared test resource fixture |
| test/src/test/java/lib/form/PasswordTest.java | Update View permission usage in password tests |
| test/src/test/java/jenkins/security/Security1809Test.java | Align tests with updated View permission model |
| test/src/test/java/jenkins/plugins/detachedtest/Marker.java | Add synthetic plugin package anchor for tests |
| test/src/test/java/jenkins/core/PluginExcerptSanitizerTest.java | Add test coverage for excerpt sanitizer core-lib |
| test/src/test/java/jenkins/core/corelib_test_plugin/ClassLoaderProbe.java | Add classloader probe helper for core-lib isolation tests |
| test/src/test/java/hudson/security/HudsonPrivateSecurityRealmTest.java | Add UI smoke tests for password toggle/caps-lock indicator |
| test/src/test/java/hudson/search/SearchTest.java | Extend global search tests to match display name; adjust view visibility expectations |
| test/src/test/java/hudson/PluginManagerTest.java | Add coverage for /pluginManager/api/json default-depth exports |
| test/src/test/java/hudson/model/ViewTest.java | Update View permission usage in tests |
| test/src/test/java/hudson/model/Security3349Test.java | Update View permission usage in tests |
| test/src/test/java/hudson/diagnosis/TooManyJobsButNoViewTest.java | Remove deprecated View.READ usage in test setup |
| test/src/test/java/hudson/cli/RemoveJobFromViewCommandTest.java | Update authorization requirements for view CLI tests |
| test/src/test/java/hudson/cli/GetViewCommandTest.java | Update CLI permission expectations to View.EXTENDED_READ |
| test/src/test/java/hudson/cli/CLIActionTest.java | Update expected exit code behavior for get-view |
| test/pom.xml | Exclude core-libs from test classpath; configure annotation processors; bump matrix-project test dep |
| src/main/scss/pages/_plugin-manager.scss | Remove sticky sidebar styling for plugin manager |
| src/main/scss/pages/_job.scss | Remove side-panel build history margin override |
| src/main/scss/pages/_index.scss | Include agent page stylesheet |
| src/main/scss/components/_side-panel-widgets.scss | Remove pane-frame margin tweak |
| src/main/scss/components/_side-panel-tasks.scss | Adjust side panel spacing/padding for tasks/search/app-bar |
| src/main/scss/components/_page-footer.scss | Hide footer in redesigned layout |
| src/main/scss/components/_breadcrumbs.scss | Fix breadcrumb layout/hover/open state and chevron behavior |
| src/main/scss/components/_app-bar.scss | Update app-bar sizing and sticky behavior |
| src/main/scss/base/_sticky.scss | Adjust “disable sticky” behavior for new layout elements |
| src/main/scss/base/_core.scss | Update page overscroll/background styling defaults |
| src/main/scss/abstracts/_theme.scss | Adjust header styling and spacing tokens |
| src/main/js/util/password-field.js | Add shared password visibility toggle + caps-lock indicator utilities |
| src/main/js/pages/sign-in/index.js | Initialize password toggle/caps-lock indicator on sign-in page |
| src/main/js/pages/register/index.js | Switch registration page to shared password-field utilities |
| src/main/js/components/notifications/index.js | Add pending-notification replay via sessionStorage |
| src/main/js/components/header/index.js | Remove scroll-based header fading logic |
| src/main/js/components/dropdowns/templates.js | Restore POST-action notifications via sessionStorage + redirect |
| src/main/js/components/dropdowns/autocomplete.js | Fix touch selection issue by preserving dropdown on focus transition |
| package.json | Bump JS toolchain versions and Yarn packageManager version |
| core/src/spotbugs/excludesFilter.xml | Add SpotBugs excludes for newly introduced patterns |
| core/src/main/resources/lib/layout/side-panel.jelly | Remove sticky side-panel attribute/behavior |
| core/src/main/resources/lib/layout/layout.jelly | Adjust page body/main content wrapper classes for new layout |
| core/src/main/resources/lib/hudson/progressive-text.js | Use more robust scroll container selection for progressive text |
| core/src/main/resources/lib/hudson/actions.jelly | Add confirmation-event special handling for tasks/actions |
| core/src/main/resources/jenkins/views/JenkinsHeader/logo.jelly | Add tooltip showing Jenkins version on logo |
| core/src/main/resources/jenkins/model/Jenkins/login.jelly | Include sign-in JS bundle; add password toggle/caps-lock indicator markup |
| core/src/main/resources/jenkins/model/details/MonitoringDetails/detail.jelly | Add monitoring details dialog UI element |
| core/src/main/resources/jenkins/model/agent/Messages.properties | Add titles for agent actions |
| core/src/main/resources/jenkins/agent/OverviewTab/index.properties | Add i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_zh_TW.properties | Add zh-TW i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_uk.properties | Add uk i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_tr.properties | Add tr i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_sv_SE.properties | Add sv-SE i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_sr.properties | Add sr i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_sl.properties | Add sl i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_sk.properties | Add sk i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_ru.properties | Add ru i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_pt_PT.properties | Add pt-PT i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_pt_BR.properties | Add pt-BR i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_pl.properties | Add pl i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_nl.properties | Add nl i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_nb_NO.properties | Add nb-NO i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_lv.properties | Add lv i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_lt.properties | Add lt i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_ko.properties | Add ko i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_ja.properties | Add ja i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_it.properties | Add it i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_he.properties | Add he i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_fr.properties | Add fr i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_fi.properties | Add fi i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_es.properties | Add es i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_de.properties | Add de i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_da.properties | Add da i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_cs.properties | Add cs i18n strings for agent overview tab |
| core/src/main/resources/jenkins/agent/OverviewTab/index_bg.properties | Add bg i18n strings for agent overview tab |
| core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly | Remove conditional tasks; rely on app-bar actions |
| core/src/main/resources/hudson/slaves/SlaveComputer/log.jelly | Convert agent log page to agent-subpage layout |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog.properties | Add disconnect dialog strings (base) |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog.jelly | Add AJAX disconnect dialog markup |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_zh_TW.properties | Add zh-TW disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_sv_SE.properties | Add sv-SE disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_sr.properties | Add sr disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_ru.properties | Add ru disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_pt_BR.properties | Add pt-BR disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_lv.properties | Add lv disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_ja.properties | Add ja disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_it.properties | Add it disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_fr.properties | Add fr disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_es.properties | Add es disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_de.properties | Add de disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_da.properties | Add da disconnect dialog i18n |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_bg.properties | Adjust bg disconnect dialog keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect.properties | Trim disconnect properties to required key(s) |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect.jelly | Convert disconnect page to agent-subpage using dialog include |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_zh_TW.properties | Adjust zh-TW disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_sv_SE.properties | Adjust sv-SE disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_sr.properties | Adjust sr disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_ru.properties | Adjust ru disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_pt_BR.properties | Adjust pt-BR disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_lv.properties | Adjust lv disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_ja.properties | Adjust ja disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_it.properties | Adjust it disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_fr.properties | Adjust fr disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_es.properties | Adjust es disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_de.properties | Adjust de disconnect keys |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_da.properties | Adjust da disconnect keys |
| core/src/main/resources/hudson/slaves/OfflineCause/LaunchFailed/cause.jelly | Update offline-cause rendering to alert styling |
| core/src/main/resources/hudson/slaves/OfflineCause/ChannelTermination/cause.jelly | Update offline-cause rendering to alert styling |
| core/src/main/resources/hudson/slaves/OfflineCause/cause.jelly | Rework offline-cause layout with icons/timestamp |
| core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly | Simplify configure entries markup for agent config |
| core/src/main/resources/hudson/slaves/ComputerLauncher/app-bar-controls.jelly | Shorten launch/relaunch labels |
| core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/signup_zh_TW.properties | Remove unused “Show” translation |
| core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/signup_pt_BR.properties | Remove unused “Show” translation |
| core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/signup_it.properties | Remove unused “Show” translation |
| core/src/main/resources/hudson/PluginManager/sidepanel.jelly | Remove sticky side-panel usage for plugin manager |
| core/src/main/resources/hudson/node_monitors/ResponseTimeMonitor/Data/cause.jelly | Update monitor cause rendering to alert styling |
| core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.jelly | Update monitor cause rendering to alert styling |
| core/src/main/resources/hudson/model/Messages.properties | Deprecate View.Read description; add View.ExtendedRead description |
| core/src/main/resources/hudson/model/Messages_zh_TW.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/Messages_sv_SE.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/Messages_sr.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/Messages_pt_BR.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/Messages_lt.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/Messages_ja.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/Messages_it.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/Messages_es.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/Messages_de.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/Messages_bg.properties | Remove View.Read description translation |
| core/src/main/resources/hudson/model/LoadStatistics/main.jelly | Suppress app-bar title in experimental agent page context |
| core/src/main/resources/hudson/model/Job/configure.jelly | Remove sticky side-panel usage in job configure UI |
| core/src/main/resources/hudson/model/Computer/sidepanel.jelly | Move to app-bar actions; adjust sidepanel tasks rendering |
| core/src/main/resources/hudson/model/Computer/setOfflineCause.properties | Fix grammar in offline-cause blurb |
| core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly | Convert offline-cause update page to agent-subpage layout |
| core/src/main/resources/hudson/model/Computer/new-agent-page.jelly | Add new agent-page entrypoint for experimental UI |
| core/src/main/resources/hudson/model/Computer/markOffline.properties | Adjust submit label text |
| core/src/main/resources/hudson/model/Computer/markOffline.jelly | Convert mark-offline page to agent-subpage layout |
| core/src/main/resources/hudson/model/Computer/load-statistics.jelly | Convert load-statistics page to agent-subpage layout |
| core/src/main/resources/hudson/model/Computer/configure.jelly | Convert agent configure page to agent-subpage layout |
| core/src/main/resources/hudson/model/Computer/builds.jelly | Convert build history page to agent-subpage layout |
| core/src/main/resources/hudson/model/Computer/app-controls.properties | Add app-controls labels for agent page dialogs/buttons |
| core/src/main/resources/hudson/model/Computer/_script.jelly | Convert agent script console into agent-subpage wrapper |
| core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java | Enable app-bar actions for agents behind new experimental flag |
| core/src/main/java/jenkins/model/menu/action/DeleteAction.java | Add DeleteAction factory for agents |
| core/src/main/java/jenkins/model/experimentalflags/NewAgentPageUserExperimentalFlag.java | Add experimental flag for new agent page UI |
| core/src/main/java/jenkins/model/details/MonitoringDetails.java | Add MonitoringDetails detail type |
| core/src/main/java/jenkins/core/PluginExcerptSanitizer.java | Introduce sanitizer SPI for plugin excerpts |
| core/src/main/java/jenkins/agent/OverviewTabFactory.java | Contribute Overview tab when agent-page flag enabled |
| core/src/main/java/jenkins/agent/OverviewTab.java | Add agent overview tab implementation |
| core/src/main/java/jenkins/agent/LogTab.java | Add agent log tab implementation |
| core/src/main/java/hudson/security/AuthorizationStrategy.java | Remove special View.READ fallback logic in view ACL |
| core/src/main/java/hudson/PluginWrapper.java | Export additional plugin fields at default API depth |
| core/src/main/java/hudson/model/ViewGroupMixIn.java | Stop filtering views by deprecated View.READ permission |
| core/src/main/java/hudson/model/UpdateSite.java | Sanitize plugin excerpt HTML (core-lib-backed) |
| core/src/main/java/hudson/model/Executor.java | Add accessor to detect pending interrupt status |
| core/src/main/java/hudson/model/AbstractBuild.java | Treat executor-driven interrupts as ABORTED, not FAILURE, for publishers |
| core/src/main/java/hudson/Functions.java | Add helper to identify action event type in Jelly rendering |
| core/src/main/java/hudson/cli/handlers/ViewOptionHandler.java | Stop enforcing View.READ during CLI view resolution |
| core/src/main/java/hudson/cli/GetViewCommand.java | Require View.EXTENDED_READ for get-view CLI |
| core-libs/validate-dependencies.groovy | Validate declared bundled-libraries list matches actual deps |
| core-libs/src/main/resources/META-INF/bundled-libraries.properties | Declare bundled core-libs artifact IDs |
| CONTRIBUTING.md | Update build guidance (skip frontend, quick-build test skip note) |
| cli/src/test/java/hudson/util/QuotedStringTokenizerTest.java | Add tests pinning quote() overload behaviors |
| cli/src/main/java/hudson/util/QuotedStringTokenizer.java | Clarify quote(String) contract in Javadoc |
| cli/pom.xml | Add annotation-indexer; exclude Processor service from shaded jar |
| bom/pom.xml | Bump Stapler, commons-codec, sezpoz versions |
| .idea/encodings.xml | Add UTF-8 encodings for core-libs paths |
| .gitignore | Ignore generated WEB-INF/core-lib output |
| .github/workflows/changelog.yml | Bump release-drafter action pin |
Files not reviewed (1)
- .idea/encodings.xml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+82
to
+87
| const notification = JSON.parse(pending); | ||
|
|
||
| window.notificationBar.show( | ||
| notification.message, | ||
| window.notificationBar[notification.type], | ||
| ); |
| </l:layout> | ||
| <l:agent-subpage title="${%Disconnect}" agent="${it}"> | ||
| <l:userExperimentalFlag var="newAgentPage" flagClassName="jenkins.model.experimentalflags.NewAgentPageUserExperimentalFlag" /> | ||
| <l:app-bar title="${newAgentPage ? '%Disconnect' : '%disconnect.computer(it.displayName)'}"/> |
| <l:agent-subpage title="${%Update offline reason}" agent="${it}"> | ||
| <l:hasPermission permission="${it.DISCONNECT}"> | ||
| <l:userExperimentalFlag var="newAgentPage" flagClassName="jenkins.model.experimentalflags.NewAgentPageUserExperimentalFlag" /> | ||
| <l:app-bar title="${newAgentPage ? '%Set Offline Reason' : '%title(it.displayName)'}"/> |
| <l:agent-subpage title="${%Mark offline}" agent="${it}"> | ||
| <l:userExperimentalFlag var="newAgentPage" flagClassName="jenkins.model.experimentalflags.NewAgentPageUserExperimentalFlag" /> | ||
|
|
||
| <l:app-bar title="${newAgentPage ? '%Take Offline' : '%title(it.displayName)'}"/> |
Comment on lines
+159
to
+163
| /** | ||
| * Factory that contributes a {@link DeleteAction} to every {@link Run} the current | ||
| * user has {@link Run#DELETE} permission on when the new run page experimental flag | ||
| * is enabled. | ||
| */ |
Comment on lines
+1745
to
+1747
| /** | ||
| * Retrieves the tabs for a given job | ||
| */ |
Comment on lines
+25
to
+27
| Disconnect=Desconectar | ||
| # You can optionally explain why you are taking this node offline, so that others can see why: | ||
| blurb=Opcionalmente você pode explicar por que esse nu00d3 está offline. |
Comment on lines
+20
to
+25
| def artifactIds = props.keySet().join(',') | ||
| project.properties['core-lib-artifact-ids'] = artifactIds | ||
|
|
||
| // Generate regex pattern for packaging excludes (include jenkins-core-libs itself + all artifact IDs) | ||
| def allIds = (['jenkins-core-libs'] + props.keySet()).join('|') | ||
| project.properties['core-lib-packaging-excludes'] = "%regex[WEB-INF/lib/(" + allIds + ")-.*\\.jar]" |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 220 out of 231 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- .idea/encodings.xml: Generated file
Suppressed comments (7)
core/src/main/resources/hudson/model/Computer/markOffline.jelly:35
- The <l:app-bar> title is built using string literals like '%Take Offline'/'%title(...)'. That will render the percent-prefixed text instead of localizing it, since Jelly localization requires the ${%...} syntax.
core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly:32 - The <l:app-bar> title uses string literals like '%Set Offline Reason'/'%title(...)', which will not be localized. Jelly messages need to be referenced via ${%...}, so this will likely display the raw '%…' text.
src/main/js/components/notifications/index.js:83 - Reading the pending dropdown notification uses JSON.parse without any guard. If sessionStorage contains malformed JSON (e.g., from an older version or manual edits), this will throw and prevent notification initialization (and possibly other page JS) from running.
core/src/main/resources/hudson/slaves/SlaveComputer/disconnect.jelly:32 - The <l:app-bar> title is constructed from string literals like '%Disconnect' and '%disconnect.computer(...)'. Those won't be localized and will likely render verbatim with the leading '%'. Use ${%...} expressions instead.
src/main/js/components/dropdowns/templates.js:319 - tryPost() now redirects only after the fetch promise resolves. If the POST fails at the network level (fetch rejects / times out), the redirect never happens and the user is left on the same page with no feedback. Consider handling rejections and always completing navigation.
cli/pom.xml:23 - Setting the Surefire 'test' selection property in the POM makes this module run only QuotedStringTokenizerTest by default, which will silently skip the rest of the CLI test suite for normal builds. Test selection should be controlled via CI/job configuration or a dedicated Maven profile, not committed as the default.
<!-- Filled in by jacoco-maven-plugin -->
<jacocoSurefireArgs />
<!-- Intentionally run only one test to reduce cycle time -->
<test>QuotedStringTokenizerTest</test>
</properties>
core/src/main/java/jenkins/model/menu/action/DeleteAction.java:181
- AgentFactory's Javadoc incorrectly references Run/Run#DELETE and claims an experimental-flag condition, but the implementation does not gate on the new agent page flag. This mismatch is confusing and can inadvertently expose the action outside the intended UI path.
14 tasks
Contributor
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
1 similar comment
Contributor
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test several pull requests
Includes pull requests:
Testing done
mvn clean verifypassedScreenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label skip-changelog
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
N/A
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.