Conversation
The runtime probe defaults to no when cross-compiling, disabling the optimized extent comparator even when the target compiler supports __int128. The test only initializes a value to zero and returns it, so executing it adds no runtime validation. Use AC_LINK_IFELSE to retain compilation and linking checks without requiring execution on the build host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-compiling currently defaults
je_cv_int128tono, disabling the optimized extent comparator even when the target compiler supports__int128. ReplaceAC_RUN_IFELSEwithAC_LINK_IFELSE: the probe only initializes a value to zero and returns it, so compilation and linking are sufficient.Tested locally with an ARM64-to-x86_64 macOS cross-build: detection changes from
notoyes, and both static and shared allocator libraries build successfully.Existing native CI tests do not cover this detection regression. I also prepared a small cross-configure assertion in an existing macOS CI entry, verified to fail before the fix and pass afterward. Happy to include that CI update if you consider it useful.
AI-assisted