Conversation
The Buy trigger in the book sidebar was a bespoke dark grey button with an absolutely positioned cart icon and a PNG caret in its own bordered cell. It now takes the secondary look from .ol-button-static, the light-DOM twin of ol-button, so its height, border, radius, shadow, font and hover come from the same tokens as every other button. The cart icon is dropped and the caret is the sprite's chevron, which rotates while the popover is open.
lokesh
marked this pull request as ready for review
September 15, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Buy button in the book sidebar was a dark grey one-off with a cart icon and a PNG caret, taller than the buttons around it. It now looks like the Preview, Search and Borrow buttons beside it, so the panel reads as one set of controls, and the caret flips when the menu is open.
Technical
The trigger uses
.ol-button-static, the light-DOM twin of<ol-button>secondary, so its size and colors come from the shared tokens.buy-popover.csskeeps only the full-width and chevron rules.Testing
Open
/books/OL24337798Mand click Buy.Screenshot
see above
Stakeholders
@cdrini @mekarpeles