Fix nullable bound on DataFetcherResult.newResult - #4418
Open
hej090224 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
DataFetcherResult.newResult()factory method.Problem:
DataFetcherResultand itsBuilderallow nullable type parameters.newResult()method declared an unboundedT.Testing:
./gradlew compileTestKotlinfailed before the Java change withType argument is not within its boundsforDataFetcherResult.newResult<String?>()../gradlew compileTestKotlinpassed after the change../gradlew test --tests graphql.execution.DataFetcherResultTestpassed: 26 tests../gradlew check -x test -x testngpassed../gradlew javadocpassed../gradlew testngpassed: 190 tests../gradlew testwas run locally on Windows and failed in unrelatedgraphql.parser.MultiSourceReaderTest.can combine files; the failure reproduces when that test is run alone and appears tied to local checkout line endings forsrc/test/resources/multisource/a.txt(w/crlf).Issue:
Fixes #4364