Skip to content
This repository was archived by the owner on Jul 21, 2021. It is now read-only.

More unused code cleaning - #1009

Merged
gorhill merged 2 commits into
gorhill:masterfrom
rhendric:cleaning
Apr 7, 2019
Merged

gorhill merged 2 commits into
gorhill:masterfrom
rhendric:cleaning

Conversation

@rhendric

Copy link
Copy Markdown
Contributor
  • remove many unused functions
  • remove XAL abstraction

@xofe

xofe commented Apr 7, 2019

Copy link
Copy Markdown
Contributor

Looks good to me, just might want to remove the <script src="/api/v1/web-embed/proxy?proxyUrl=https%3A%2F%2Fgithub.com%2Fgorhill%2FuMatrix%2Fpull%2Fjs%2Fxal.js&mode=full"></script> line in ./src/background.html as you've deleted the file

@rhendric

rhendric commented Apr 7, 2019

Copy link
Copy Markdown
Contributor Author

🤦‍♂️ Yup, good point, did it!

@gorhill
gorhill merged commit 3f2916e into gorhill:master Apr 7, 2019
@gorhill

gorhill commented Apr 7, 2019

Copy link
Copy Markdown
Owner

Thanks.

@rhendric
rhendric deleted the cleaning branch April 7, 2019 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants