Skip to content

fix(ci): patch BC check for internal final property fix - #9697

Open
bshaffer wants to merge 2 commits into
mainfrom
fix-bc-check-for-servicescopes
Open

fix(ci): patch BC check for internal final property fix#9697
bshaffer wants to merge 2 commits into
mainfrom
fix-bc-check-for-servicescopes

Conversation

@bshaffer

@bshaffer bshaffer commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Patches the changes made in Roave/BackwardCompatibilityCheck#1005 (in case this takes a long time to review/merge/release)

@bshaffer
bshaffer requested a review from a team as a code owner September 16, 2026 18:27
zhumin8
zhumin8 approved these changes Sep 16, 2026
View reviewed changes

@zhumin8 zhumin8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
nit: can you add a TODO comment linking the issue in BackwardCompatibilityCheck, so it is a bit easier to know when we can remove this?

bshaffer
bshaffer commented Sep 16, 2026
View reviewed changes
Comment thread .github/workflows/release-checks.yaml
@bshaffer

bshaffer commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

LGTM. nit: can you add a TODO comment linking the issue in BackwardCompatibilityCheck, so it is a bit easier to know when we can remove this?

good idea, done in b3e6066

@bshaffer bshaffer added the next release PRs to be included in the next release label Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhumin8 zhumin8 zhumin8 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

next release PRs to be included in the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bshaffer @zhumin8