docs: add inline adaptive banner snippets for developer docs - #1498
Open
okorohelijah wants to merge 1 commit into
Open
okorohelijah wants to merge 1 commit into
okorohelijah wants to merge 1 commit into
Conversation
okorohelijah
force-pushed
the
add-recycle-banner-snippet-tags
branch
2 times, most recently
from
September 16, 2026 17:18
2a7f4de to
cd538c4
Compare
okorohelijah
marked this pull request as ready for review
September 16, 2026 18:02
malandr2
requested changes
Sep 16, 2026
malandr2
left a comment
Collaborator
There was a problem hiding this comment.
Could you move the snippets you want to use in the developer doc to a dedicated inline_adaptive_banner_snippets.dart snippets file in https://github.com/googleads/googleads-mobile-flutter/tree/main/packages/google_mobile_ads/example/lib/snippets?
The sample code and snippets are separate by design. That way you don't have to fight with the EXCLUDE tags that can be distracting from the actual code
You can keep the comments changes but revert the includecode tags in this file
okorohelijah
force-pushed
the
add-recycle-banner-snippet-tags
branch
from
September 16, 2026 20:48
cd538c4 to
a6a2d40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated
inline_adaptive_banner_snippets.dartfile underexample/lib/snippets/containing region-tagged snippets for the upcoming banner recycling developer guide.Region tags added:
track_positions— cache size, ad interval, and the position/size tracking mapsrecycle_banner_ad— the recycling lookup logic usingisMountedcreate_banner_ad— inline adaptive ad creation with dynamic widthdisplay_ads_in_list— rendering ads at intervals in aListView.builderdispose_ads— disposing all cached adsAlso tidies a few comments in
multi_adaptive_inline_with_recycle_example.dart(noincludecodetags in the sample, per review feedback).