Skip to content

Fix type annotations for Transaction in model.py. #118

Description

@dseomn

Currently model.py uses google.cloud.spanner_v1.transaction.Transaction for all the transaction parameters, but I think the read-only methods are designed to work with google.cloud.spanner_v1.snapshot.Snapshot too. Snapshot is available through the Spanner ORM API in spanner_orm.api.SpannerReadApi.run_read_only() and spanner_orm.decorator.transactional_read(), so we really should support using correct type annotations for Snapshot. Another thing to consider is whether there should be any support for google.cloud.spanner_v1.batch.Batch in write-only Model methods.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions