Skip to content

fixed failing starlette tests - #1491

Merged
francbartoli merged 1 commit into
geopython:masterfrom
ricardogsilva:1490-most-recent-version-of-starlette-breaks-pygeoapi-ci
Jan 15, 2024
Merged

francbartoli merged 1 commit into
geopython:masterfrom
ricardogsilva:1490-most-recent-version-of-starlette-breaks-pygeoapi-ci

Conversation

@ricardogsilva

Copy link
Copy Markdown
Member

Overview

This PR modifies the initialization of the starlette test client used in pygeoapi tests in order to comply with
the lastest changes introduced in starlette v0.35.0, specifically the merge of Kludex/starlette#2400

The change proposed in this PR is to not pass a root_path to the starlette test client, as the new starlette behavior is now to have mounted apps remove the root path when routing - since in the failing tests, which are checking the apirules functionality, pygeoapi is submounting routes under the url_prefix path.

Related issue / discussion

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@ricardogsilva
ricardogsilva marked this pull request as ready for review January 12, 2024 11:14
@francbartoli
francbartoli merged commit 62b8d67 into geopython:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

most recent version of starlette breaks pygeoapi CI

2 participants