Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Added Firestore's equivalent to RDB's FirebaseList and AnimatedFirebaseList - #757

Closed
gildaswise wants to merge 11 commits into
flutter-team-archive:masterfrom
gildaswise:firestore_ui
Closed

gildaswise wants to merge 11 commits into
flutter-team-archive:masterfrom
gildaswise:firestore_ui

Conversation

@gildaswise

@gildaswise gildaswise commented Sep 3, 2018

Copy link
Copy Markdown

Resolving issue #17332.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@gildaswise

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 3, 2018
@kroikie kroikie self-assigned this Sep 4, 2018
@gildaswise

gildaswise commented Sep 18, 2018

Copy link
Copy Markdown
Author

Had to add ? to DocumentSnapshot's documentID getter, it was returning an exception on the tests.

/// Returns the ID of the snapshot's document
String get documentID => _path?.split('/')?.last;

Also, removed new keywords from the example and changed MessageList to the new FirestoreAnimatedList.

Is this ready for review as the checks say or should I add anything else, @kroikie?

Edit: also, if anyone wants to test this before merging, just add this to your pubspec:

cloud_firestore:
  git:
    url: [email protected]:flutter/plugins.git
    path: packages/cloud_firestore
    ref: f380311

(if git@ doesn't work, change it to https://)

@kroikie

kroikie commented Oct 3, 2018

Copy link
Copy Markdown
Contributor

@gildaswise Thanks for this PR, however we are trying to focus on getting these plugins functionally complete before adding UI widgets. We would also likely make those UI widgets in a separate repo. I'll close this one, look out for when we start work on the UI widgets.

@kroikie kroikie closed this Oct 3, 2018
@gildaswise

Copy link
Copy Markdown
Author

@kroikie Would be okay if I released this as a separate Dart plugin depending on cloud_firestore?

@kroikie

kroikie commented Oct 3, 2018

Copy link
Copy Markdown
Contributor

@gildaswise Sure, that would be cool however note that the cloud_firestore plugin is not yet 1.0.0 so it may change so if you are ok with a bit of change then go for it.

@Elgeor

Elgeor commented Oct 3, 2018

Copy link
Copy Markdown

@kroikie Would be okay if I released this as a separate Dart plugin depending on cloud_firestore?

Can you please mention here name of this plugin after release?

@gildaswise

Copy link
Copy Markdown
Author

@Elgeor No problem! It'll be firestore_ui and I'll release it in a few hours

@gildaswise

Copy link
Copy Markdown
Author

I actually got a lot busy and more than a few hours have passed, but finally firestore_ui is available as a package! You can see it on pub here!

@Elgeor @branflake2267 @kroikie

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants