Added Firestore's equivalent to RDB's FirebaseList and AnimatedFirebaseList - #757
gildaswise wants to merge 11 commits into
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
9c96c1f to
62be715
Compare
…st, onValue should be called after
fbc345f to
5a8d159
Compare
|
Had to add /// Returns the ID of the snapshot's document
String get documentID => _path?.split('/')?.last;Also, removed Is this ready for review as the checks say or should I add anything else, @kroikie? Edit: also, if anyone wants to test this before merging, just add this to your pubspec: (if |
|
@gildaswise Thanks for this PR, however we are trying to focus on getting these plugins functionally complete before adding UI widgets. We would also likely make those UI widgets in a separate repo. I'll close this one, look out for when we start work on the UI widgets. |
|
@kroikie Would be okay if I released this as a separate Dart plugin depending on cloud_firestore? |
|
@gildaswise Sure, that would be cool however note that the cloud_firestore plugin is not yet 1.0.0 so it may change so if you are ok with a bit of change then go for it. |
Can you please mention here name of this plugin after release? |
|
@Elgeor No problem! It'll be |
|
I actually got a lot busy and more than a few hours have passed, but finally |
Resolving issue #17332.