Skip to content

Extract the publish panel warning indicator into a small component #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canova merged 1 commit into from
Aug 24, 2026
+21 −18
Merged

Extract the publish panel warning indicator into a small component #6282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions src/components/app/MenuButtons/Publish.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,30 +225,20 @@ class PublishPanelImpl extends React.PureComponent<PublishProps, {}> {
? this._renderCheckbox(
'includePrivateBrowsingData',
'MenuButtons--publish--renderCheckbox-label-private-browsing',
<Localized
id="MenuButtons--publish--renderCheckbox-label-private-browsing-warning-image"
attrs={{ title: true }}
>
<span
className="publishPanelDataChoicesIndicator"
title="This profile contains private browsing data"
/>
</Localized>
<WarningIndicator
l10nId="MenuButtons--publish--renderCheckbox-label-private-browsing-warning-image"
title="This profile contains private browsing data"
/>
)
: null}
{profileHasJSTracingArgumentValues
? this._renderCheckbox(
'includeArgumentValues',
'MenuButtons--publish--renderCheckbox-label-argument-values',
<Localized
id="MenuButtons--publish--renderCheckbox-label-argument-values-warning-image"
attrs={{ title: true }}
>
<span
className="publishPanelDataChoicesIndicator"
title="This profile contains function argument values recorded from the page, which may include personal data"
/>
</Localized>
<WarningIndicator
l10nId="MenuButtons--publish--renderCheckbox-label-argument-values-warning-image"
title="This profile contains function argument values recorded from the page, which may include personal data"
/>
)
: null}
</div>
Expand Down Expand Up @@ -444,6 +434,19 @@ type DownloadButtonProps = {
readonly primary?: boolean;
};

type WarningIndicatorProps = {
readonly l10nId: string;
readonly title: string;
};

function WarningIndicator({ l10nId, title }: WarningIndicatorProps) {
return (
<Localized id={l10nId} attrs={{ title: true }}>
<span className="publishPanelDataChoicesIndicator" title={title} />
</Localized>
);
}

/**
* The DownloadButton handles unpacking the compressed profile promise.
*/
Expand Down
Loading