Skip to content

Fix dark mode contrast of the warning icons in the publish panel #6280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canova merged 2 commits into from
Aug 24, 2026
Merged

Fix dark mode contrast of the warning icons in the publish panel #6280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1383214
Fix dark mode contrast of the warning icons in the publish panel
canova Aug 23, 2026
81694a1
Merge branch 'main' into push-uztkvotquvoo
canova Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/components/app/MenuButtons/Publish.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
--internal-upload-percentage-foreground-color: var(--blue-60);
--internal-upload-bar-background-color: var(--grey-40);
--internal-upload-bar-inner-background-color: var(--blue-50);
--internal-warning-indicator-icon: url(../../../../res/img/svg/warning.svg);
}

:root.dark-mode {
Expand All @@ -80,6 +81,7 @@
--internal-upload-percentage-foreground-color: var(--blue-60);
--internal-upload-bar-background-color: var(--grey-40);
--internal-upload-bar-inner-background-color: var(--blue-50);
--internal-warning-indicator-icon: url(../../../../res/img/svg/warning-light.svg);
}
}

Expand Down Expand Up @@ -115,7 +117,11 @@
}

.publishPanelDataChoicesIndicator {
display: inline-block;
width: 16px;
height: 16px;
margin-left: 8px;
background: var(--internal-warning-indicator-icon) center no-repeat;
vertical-align: middle;
}

Expand Down
8 changes: 2 additions & 6 deletions src/components/app/MenuButtons/Publish.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ import explicitConnect, {
type ConnectedProps,
} from 'firefox-profiler/utils/connect';

import WarningImage from 'firefox-profiler-res/img/svg/warning.svg';

import type {
Profile,
CheckedSharingOptions,
Expand Down Expand Up @@ -231,9 +229,8 @@ class PublishPanelImpl extends React.PureComponent<PublishProps, {}> {
id="MenuButtons--publish--renderCheckbox-label-private-browsing-warning-image"
attrs={{ title: true }}
>
<img
<span
className="publishPanelDataChoicesIndicator"
src={WarningImage}
title="This profile contains private browsing data"
/>
</Localized>
Expand All @@ -247,9 +244,8 @@ class PublishPanelImpl extends React.PureComponent<PublishProps, {}> {
id="MenuButtons--publish--renderCheckbox-label-argument-values-warning-image"
attrs={{ title: true }}
>
<img
<span
className="publishPanelDataChoicesIndicator"
src={WarningImage}
title="This profile contains function argument values recorded from the page, which may include personal data"
/>
</Localized>
Expand Down
Loading