Only call getRawFrameTableBuilderWithExistingContents once per symbolication batch. - #6233
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6233 +/- ##
=======================================
Coverage 83.68% 83.69%
=======================================
Files 348 348
Lines 37394 37403 +9
Branches 10497 10498 +1
=======================================
+ Hits 31294 31303 +9
Misses 5673 5673
Partials 427 427 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…olication batch. Fixes firefox-devtools#6232. Before: https://share.firefox.dev/3UaE2Pt After: https://share.firefox.dev/4fNirnE Create the mutable tables once per batch and let each step mutate them in place. This avoids cloning tables unnecessarily. Unrelated to the main change in this patch, this also replaces the linear scan of the sources table, which ran once per newly created func, with a filename-to-source-index map built once per batch.
mstange
force-pushed
the
push-ywuyywqpnnoq
branch
from
August 3, 2026 13:20
e6644db to
7c94a15
Compare
mstange
enabled auto-merge
August 5, 2026 13:32
Merged
canova
added a commit
that referenced
this pull request
Aug 10, 2026
Changes: [fatadel] Create the Network track from the timeline-network schema display location (#6224) [Markus Stange] Only call `getRawFrameTableBuilderWithExistingContents` once per symbolication batch. (#6233) [fatadel] Improve discoverability of downloading a local profile (#6216) [Nazım Can Altınova] Handle the cli daemon startup failures more gracefully with better errors (#6241) [Nazım Can Altınova] Add the ability to apply source maps from the CLI (#6229) [Nazım Can Altınova] Handle Text and Log marker payloads with their marker schema (#6247) [Nazım Can Altınova] Bump the Gecko profile version to make sure that the Text and Log marker changes are picked up in the frontends (#6252) [fatadel] Deactivate a menu button as soon as its panel is dismissed (#6251) [Nazım Can Altınova] 🔃 Sync: l10n -> main (August 10, 2026) (#6253) [Nazım Can Altınova] Bump profiler-cli version to 0.8.0 (#6254) And special thanks to our localizers: de: Ger de: Michael Köhler el: George kitsoukakis en-CA: chutten en-CA: Saurabh en-GB: Ian Neal es-CL: ravmn fy-NL, nl: Fjoerfoks fr: Théo Chevalier fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Fjoerfoks ru: michellemelsspam ru: Valery Ledovskoy tr: giray tr: Selim Şumlu zh-TW: Pin-guang Chen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Fixes #6232.
Before: https://share.firefox.dev/3UaE2Pt (35s jank)
After: https://share.firefox.dev/4fNirnE (8.8s jank, 4x faster)
Create the mutable tables once per batch and let each step mutate them in place. This avoids cloning tables unnecessarily.
Unrelated to the main change in this patch, this also replaces the linear scan of the sources table, which ran once per newly created func, with a filename-to-source-index map built once per batch.