From 5c051839fa66c287d1868c6259fb369259c898cd Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 00:01:09 -0400
Subject: [PATCH 01/18] fix heatmap cmap and vmin vmax, add heatmap tests

---
 examples/desktop/heatmap/__init__.py          |  0
 examples/desktop/heatmap/heatmap.py           | 37 +++++++++++++++++
 examples/desktop/heatmap/heatmap_cmap.py      | 39 ++++++++++++++++++
 examples/desktop/heatmap/heatmap_data.py      | 41 +++++++++++++++++++
 examples/desktop/heatmap/heatmap_vmin_vmax.py | 40 ++++++++++++++++++
 fastplotlib/graphics/_features/_colors.py     | 23 ++++++++++-
 fastplotlib/graphics/image.py                 | 20 ---------
 7 files changed, 179 insertions(+), 21 deletions(-)
 create mode 100644 examples/desktop/heatmap/__init__.py
 create mode 100644 examples/desktop/heatmap/heatmap.py
 create mode 100644 examples/desktop/heatmap/heatmap_cmap.py
 create mode 100644 examples/desktop/heatmap/heatmap_data.py
 create mode 100644 examples/desktop/heatmap/heatmap_vmin_vmax.py

diff --git a/examples/desktop/heatmap/__init__.py b/examples/desktop/heatmap/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/examples/desktop/heatmap/heatmap.py b/examples/desktop/heatmap/heatmap.py
new file mode 100644
index 000000000..6c375aee7
--- /dev/null
+++ b/examples/desktop/heatmap/heatmap.py
@@ -0,0 +1,37 @@
+"""
+Simple Heatmap
+==============
+Example showing how to plot a heatmap
+"""
+
+# test_example = true
+
+import fastplotlib as fpl
+import numpy as np
+
+plot = fpl.Plot()
+# to force a specific framework such as glfw:
+# plot = fpl.Plot(canvas="glfw")
+
+xs = np.linspace(0, 1_000, 20_000)
+
+sine = np.sin(xs)
+cosine = np.cos(xs)
+
+# alternating sines and cosines
+data = np.zeros((10_000, 20_000), dtype=np.float32)
+data[::2] = sine
+data[1::2] = cosine
+
+# plot the image data
+heatmap_graphic = plot.add_heatmap(data=data, name="heatmap")
+
+plot.show()
+
+plot.canvas.set_logical_size(1500, 1500)
+
+plot.auto_scale()
+
+if __name__ == "__main__":
+    print(__doc__)
+    fpl.run()
diff --git a/examples/desktop/heatmap/heatmap_cmap.py b/examples/desktop/heatmap/heatmap_cmap.py
new file mode 100644
index 000000000..452a13598
--- /dev/null
+++ b/examples/desktop/heatmap/heatmap_cmap.py
@@ -0,0 +1,39 @@
+"""
+Heatmap change cmap
+===================
+Change the cmap of a heatmap
+"""
+
+# test_example = true
+
+import fastplotlib as fpl
+import numpy as np
+
+plot = fpl.Plot()
+# to force a specific framework such as glfw:
+# plot = fpl.Plot(canvas="glfw")
+
+xs = np.linspace(0, 1_000, 20_000)
+
+sine = np.sin(xs)
+cosine = np.cos(xs)
+
+# alternating sines and cosines
+data = np.zeros((10_000, 20_000), dtype=np.float32)
+data[::2] = sine
+data[1::2] = cosine
+
+# plot the image data
+heatmap_graphic = plot.add_heatmap(data=data, name="heatmap")
+
+plot.show()
+
+plot.canvas.set_logical_size(1500, 1500)
+
+plot.auto_scale()
+
+heatmap_graphic.cmap = "viridis"
+
+if __name__ == "__main__":
+    print(__doc__)
+    fpl.run()
diff --git a/examples/desktop/heatmap/heatmap_data.py b/examples/desktop/heatmap/heatmap_data.py
new file mode 100644
index 000000000..3a0125515
--- /dev/null
+++ b/examples/desktop/heatmap/heatmap_data.py
@@ -0,0 +1,41 @@
+"""
+Heatmap change data
+===================
+Change the data of a heatmap
+"""
+
+# test_example = true
+
+import fastplotlib as fpl
+import numpy as np
+
+plot = fpl.Plot()
+# to force a specific framework such as glfw:
+# plot = fpl.Plot(canvas="glfw")
+
+xs = np.linspace(0, 1_000, 20_000)
+
+sine = np.sin(xs)
+cosine = np.cos(xs)
+
+# alternating sines and cosines
+data = np.zeros((10_000, 20_000), dtype=np.float32)
+data[::2] = sine
+data[1::2] = cosine
+
+# plot the image data
+heatmap_graphic = plot.add_heatmap(data=data, name="heatmap")
+
+plot.show()
+
+plot.canvas.set_logical_size(1500, 1500)
+
+plot.auto_scale()
+
+heatmap_graphic.data[:5_000] = sine
+heatmap_graphic.data[5_000:] = cosine
+
+
+if __name__ == "__main__":
+    print(__doc__)
+    fpl.run()
diff --git a/examples/desktop/heatmap/heatmap_vmin_vmax.py b/examples/desktop/heatmap/heatmap_vmin_vmax.py
new file mode 100644
index 000000000..095b25fab
--- /dev/null
+++ b/examples/desktop/heatmap/heatmap_vmin_vmax.py
@@ -0,0 +1,40 @@
+"""
+Heatmap change vmin vmax
+========================
+Change the vmin vmax of a heatmap
+"""
+
+# test_example = true
+
+import fastplotlib as fpl
+import numpy as np
+
+plot = fpl.Plot()
+# to force a specific framework such as glfw:
+# plot = fpl.Plot(canvas="glfw")
+
+xs = np.linspace(0, 1_000, 20_000)
+
+sine = np.sin(xs)
+cosine = np.cos(xs)
+
+# alternating sines and cosines
+data = np.zeros((10_000, 20_000), dtype=np.float32)
+data[::2] = sine
+data[1::2] = cosine
+
+# plot the image data
+heatmap_graphic = plot.add_heatmap(data=data, name="heatmap")
+
+plot.show()
+
+plot.canvas.set_logical_size(1500, 1500)
+
+plot.auto_scale()
+
+heatmap_graphic.cmap.vmin = -0.5
+heatmap_graphic.cmap.vmax = 0.5
+
+if __name__ == "__main__":
+    print(__doc__)
+    fpl.run()
diff --git a/fastplotlib/graphics/_features/_colors.py b/fastplotlib/graphics/_features/_colors.py
index 85014155d..b6723b34b 100644
--- a/fastplotlib/graphics/_features/_colors.py
+++ b/fastplotlib/graphics/_features/_colors.py
@@ -401,8 +401,29 @@ class HeatmapCmapFeature(ImageCmapFeature):
     """
 
     def _set(self, cmap_name: str):
+        # in heatmap we use one material for all ImageTiles
         self._parent._material.map.data[:] = make_colors(256, cmap_name)
         self._parent._material.map.update_range((0, 0, 0), size=(256, 1, 1))
-        self.name = cmap_name
+        self._name = cmap_name
 
         self._feature_changed(key=None, new_data=self.name)
+
+    @property
+    def vmin(self) -> float:
+        """Minimum contrast limit."""
+        return self._parent._material.clim[0]
+
+    @vmin.setter
+    def vmin(self, value: float):
+        """Minimum contrast limit."""
+        self._parent._material.clim = (value, self._parent._material.clim[1])
+
+    @property
+    def vmax(self) -> float:
+        """Maximum contrast limit."""
+        return self._parent._material.clim[1]
+
+    @vmax.setter
+    def vmax(self, value: float):
+        """Maximum contrast limit."""
+        self._parent._material.clim = (self._parent._material.clim[0], value)
\ No newline at end of file
diff --git a/fastplotlib/graphics/image.py b/fastplotlib/graphics/image.py
index 12ac9e41d..10f09eefb 100644
--- a/fastplotlib/graphics/image.py
+++ b/fastplotlib/graphics/image.py
@@ -480,26 +480,6 @@ def __init__(
             # set it with the actual data
             self.data = data
 
-    @property
-    def vmin(self) -> float:
-        """Minimum contrast limit."""
-        return self._material.clim[0]
-
-    @vmin.setter
-    def vmin(self, value: float):
-        """Minimum contrast limit."""
-        self._material.clim = (value, self._material.clim[1])
-
-    @property
-    def vmax(self) -> float:
-        """Maximum contrast limit."""
-        return self._material.clim[1]
-
-    @vmax.setter
-    def vmax(self, value: float):
-        """Maximum contrast limit."""
-        self._material.clim = (self._material.clim[0], value)
-
     def set_feature(self, feature: str, new_data: Any, indices: Any):
         pass
 

From 2d223c629ff8213ad97956741edd55878c914161 Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 00:52:53 -0400
Subject: [PATCH 02/18] add heatmap to tests glob

---
 examples/tests/testutils.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/tests/testutils.py b/examples/tests/testutils.py
index 6155f8763..2f3989789 100644
--- a/examples/tests/testutils.py
+++ b/examples/tests/testutils.py
@@ -16,6 +16,7 @@
 # examples live in themed sub-folders
 example_globs = [
     "image/*.py",
+    "heatmap/*.py"
     "scatter/*.py",
     "line/*.py",
     "line_collection/*.py",

From c410856db094ada33e318858c66a070051b2dee4 Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 01:20:22 -0400
Subject: [PATCH 03/18] remove old commented code

---
 fastplotlib/widgets/image.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fastplotlib/widgets/image.py b/fastplotlib/widgets/image.py
index a9ebfafb4..28b34cbb6 100644
--- a/fastplotlib/widgets/image.py
+++ b/fastplotlib/widgets/image.py
@@ -869,9 +869,6 @@ def set_data(
         # force graphics to update
         self.current_index = self.current_index
 
-        # if reset_vmin_vmax:
-        #     self.reset_vmin_vmax()
-
     def show(self, toolbar: bool = True, sidecar: bool = False, sidecar_kwargs: dict = None):
         """
         Show the widget

From c41dd7b836c541019d1993cb4eaed493ab611283 Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 01:20:52 -0400
Subject: [PATCH 04/18] Plot.auto_scale() skipped if scene is empty

---
 fastplotlib/layouts/_plot_area.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fastplotlib/layouts/_plot_area.py b/fastplotlib/layouts/_plot_area.py
index 2060850c2..7590bad10 100644
--- a/fastplotlib/layouts/_plot_area.py
+++ b/fastplotlib/layouts/_plot_area.py
@@ -495,7 +495,9 @@ def auto_scale(self, maintain_aspect: bool = False, zoom: float = 0.8):
             zoom value for the camera after auto-scaling, if zoom = 1.0 then the graphics
             in the scene will fill the entire canvas.
         """
-        # hacky workaround for now until we decided if we want to put selectors in their own scene
+        if not len(self.scene.children) > 0:
+            return
+        # hacky workaround for now until we decide if we want to put selectors in their own scene
         # remove all selectors from a scene to calculate scene bbox
         for selector in self.selectors:
             self.scene.remove(selector.world_object)

From 8d9f69f62f99c328d44390344f1a452d5bd10bbd Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 01:21:53 -0400
Subject: [PATCH 05/18] add another gridplot test

---
 .../desktop/gridplot/gridplot_non_square.py   | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 examples/desktop/gridplot/gridplot_non_square.py

diff --git a/examples/desktop/gridplot/gridplot_non_square.py b/examples/desktop/gridplot/gridplot_non_square.py
new file mode 100644
index 000000000..a41bcd9f4
--- /dev/null
+++ b/examples/desktop/gridplot/gridplot_non_square.py
@@ -0,0 +1,34 @@
+"""
+GridPlot Simple
+============
+Example showing simple 2x2 GridPlot with Standard images from imageio.
+"""
+
+# test_example = true
+
+import fastplotlib as fpl
+import imageio.v3 as iio
+
+
+plot = fpl.GridPlot(shape=(2, 2), controllers="sync")
+# to force a specific framework such as glfw:
+# plot = fpl.GridPlot(canvas="glfw")
+
+im = iio.imread("imageio:clock.png")
+im2 = iio.imread("imageio:astronaut.png")
+im3 = iio.imread("imageio:coffee.png")
+
+plot[0, 0].add_image(data=im)
+plot[0, 1].add_image(data=im2)
+plot[1, 0].add_image(data=im3)
+
+plot.show()
+
+plot.canvas.set_logical_size(800, 800)
+
+for subplot in plot:
+    subplot.auto_scale()
+
+if __name__ == "__main__":
+    print(__doc__)
+    fpl.run()

From dde480d042433596eac4420bc0e14ca29e10b4d0 Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 01:32:56 -0400
Subject: [PATCH 06/18] a comma

---
 examples/tests/testutils.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/tests/testutils.py b/examples/tests/testutils.py
index 2f3989789..5f6772fb7 100644
--- a/examples/tests/testutils.py
+++ b/examples/tests/testutils.py
@@ -16,7 +16,7 @@
 # examples live in themed sub-folders
 example_globs = [
     "image/*.py",
-    "heatmap/*.py"
+    "heatmap/*.py",
     "scatter/*.py",
     "line/*.py",
     "line_collection/*.py",

From fb9737fb7e0bccbeacc63b25680fced4fff9d34c Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 01:40:21 -0400
Subject: [PATCH 07/18] smaller heatmap test image, github actions cannot
 handle 10k x 20k

---
 examples/desktop/heatmap/heatmap.py           | 2 +-
 examples/desktop/heatmap/heatmap_cmap.py      | 4 ++--
 examples/desktop/heatmap/heatmap_data.py      | 2 +-
 examples/desktop/heatmap/heatmap_vmin_vmax.py | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/examples/desktop/heatmap/heatmap.py b/examples/desktop/heatmap/heatmap.py
index 6c375aee7..9874ca788 100644
--- a/examples/desktop/heatmap/heatmap.py
+++ b/examples/desktop/heatmap/heatmap.py
@@ -19,7 +19,7 @@
 cosine = np.cos(xs)
 
 # alternating sines and cosines
-data = np.zeros((10_000, 20_000), dtype=np.float32)
+data = np.zeros((10_000, 10_000), dtype=np.float32)
 data[::2] = sine
 data[1::2] = cosine
 
diff --git a/examples/desktop/heatmap/heatmap_cmap.py b/examples/desktop/heatmap/heatmap_cmap.py
index 452a13598..afc67f5b8 100644
--- a/examples/desktop/heatmap/heatmap_cmap.py
+++ b/examples/desktop/heatmap/heatmap_cmap.py
@@ -13,13 +13,13 @@
 # to force a specific framework such as glfw:
 # plot = fpl.Plot(canvas="glfw")
 
-xs = np.linspace(0, 1_000, 20_000)
+xs = np.linspace(0, 1_000, 10_000)
 
 sine = np.sin(xs)
 cosine = np.cos(xs)
 
 # alternating sines and cosines
-data = np.zeros((10_000, 20_000), dtype=np.float32)
+data = np.zeros((10_000, 10_000), dtype=np.float32)
 data[::2] = sine
 data[1::2] = cosine
 
diff --git a/examples/desktop/heatmap/heatmap_data.py b/examples/desktop/heatmap/heatmap_data.py
index 3a0125515..1a2b9766a 100644
--- a/examples/desktop/heatmap/heatmap_data.py
+++ b/examples/desktop/heatmap/heatmap_data.py
@@ -19,7 +19,7 @@
 cosine = np.cos(xs)
 
 # alternating sines and cosines
-data = np.zeros((10_000, 20_000), dtype=np.float32)
+data = np.zeros((10_000, 10_000), dtype=np.float32)
 data[::2] = sine
 data[1::2] = cosine
 
diff --git a/examples/desktop/heatmap/heatmap_vmin_vmax.py b/examples/desktop/heatmap/heatmap_vmin_vmax.py
index 095b25fab..291fcec0e 100644
--- a/examples/desktop/heatmap/heatmap_vmin_vmax.py
+++ b/examples/desktop/heatmap/heatmap_vmin_vmax.py
@@ -19,7 +19,7 @@
 cosine = np.cos(xs)
 
 # alternating sines and cosines
-data = np.zeros((10_000, 20_000), dtype=np.float32)
+data = np.zeros((10_000, 10_000), dtype=np.float32)
 data[::2] = sine
 data[1::2] = cosine
 

From e33cccfbb731bc0ced6eb669e054c6247435707e Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 01:44:18 -0400
Subject: [PATCH 08/18] dims

---
 examples/desktop/heatmap/heatmap.py           | 2 +-
 examples/desktop/heatmap/heatmap_data.py      | 2 +-
 examples/desktop/heatmap/heatmap_vmin_vmax.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/examples/desktop/heatmap/heatmap.py b/examples/desktop/heatmap/heatmap.py
index 9874ca788..45c340cbd 100644
--- a/examples/desktop/heatmap/heatmap.py
+++ b/examples/desktop/heatmap/heatmap.py
@@ -13,7 +13,7 @@
 # to force a specific framework such as glfw:
 # plot = fpl.Plot(canvas="glfw")
 
-xs = np.linspace(0, 1_000, 20_000)
+xs = np.linspace(0, 1_000, 10_000)
 
 sine = np.sin(xs)
 cosine = np.cos(xs)
diff --git a/examples/desktop/heatmap/heatmap_data.py b/examples/desktop/heatmap/heatmap_data.py
index 1a2b9766a..78e819ab8 100644
--- a/examples/desktop/heatmap/heatmap_data.py
+++ b/examples/desktop/heatmap/heatmap_data.py
@@ -13,7 +13,7 @@
 # to force a specific framework such as glfw:
 # plot = fpl.Plot(canvas="glfw")
 
-xs = np.linspace(0, 1_000, 20_000)
+xs = np.linspace(0, 1_000, 10_000)
 
 sine = np.sin(xs)
 cosine = np.cos(xs)
diff --git a/examples/desktop/heatmap/heatmap_vmin_vmax.py b/examples/desktop/heatmap/heatmap_vmin_vmax.py
index 291fcec0e..7aae1d6d3 100644
--- a/examples/desktop/heatmap/heatmap_vmin_vmax.py
+++ b/examples/desktop/heatmap/heatmap_vmin_vmax.py
@@ -13,7 +13,7 @@
 # to force a specific framework such as glfw:
 # plot = fpl.Plot(canvas="glfw")
 
-xs = np.linspace(0, 1_000, 20_000)
+xs = np.linspace(0, 1_000, 10_000)
 
 sine = np.sin(xs)
 cosine = np.cos(xs)

From eac95960fd174fd6e9ecd06682d3d363c91c4dfc Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 01:50:23 -0400
Subject: [PATCH 09/18] add heatmap screenshots

---
 examples/desktop/screenshots/heatmap.png           | 3 +++
 examples/desktop/screenshots/heatmap_cmap.png      | 3 +++
 examples/desktop/screenshots/heatmap_data.png      | 3 +++
 examples/desktop/screenshots/heatmap_vmin_vmax.png | 3 +++
 4 files changed, 12 insertions(+)
 create mode 100644 examples/desktop/screenshots/heatmap.png
 create mode 100644 examples/desktop/screenshots/heatmap_cmap.png
 create mode 100644 examples/desktop/screenshots/heatmap_data.png
 create mode 100644 examples/desktop/screenshots/heatmap_vmin_vmax.png

diff --git a/examples/desktop/screenshots/heatmap.png b/examples/desktop/screenshots/heatmap.png
new file mode 100644
index 000000000..d0df1510a
--- /dev/null
+++ b/examples/desktop/screenshots/heatmap.png
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:6c19d6454e79d92074bac01175dfbb8506e882ea55b626c0b2357960ed6e294f
+size 163655
diff --git a/examples/desktop/screenshots/heatmap_cmap.png b/examples/desktop/screenshots/heatmap_cmap.png
new file mode 100644
index 000000000..db3038dee
--- /dev/null
+++ b/examples/desktop/screenshots/heatmap_cmap.png
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:0328eec32f13042e3e2f243793317e180bba1353fe961604ecad3f38463b8809
+size 156419
diff --git a/examples/desktop/screenshots/heatmap_data.png b/examples/desktop/screenshots/heatmap_data.png
new file mode 100644
index 000000000..96169ec77
--- /dev/null
+++ b/examples/desktop/screenshots/heatmap_data.png
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:4a376c24fa123088be69f807ec5212cb5ed5680b146ce9d62df584790c632845
+size 20838
diff --git a/examples/desktop/screenshots/heatmap_vmin_vmax.png b/examples/desktop/screenshots/heatmap_vmin_vmax.png
new file mode 100644
index 000000000..2a809d545
--- /dev/null
+++ b/examples/desktop/screenshots/heatmap_vmin_vmax.png
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:3eb12ad590aa8260f2cf722abadf5b51bcb7d5a8d8d1cb05b7711b50331da07a
+size 165937

From 17b12b2604ae8a932ffe56d5355a633617d92a5b Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 01:50:40 -0400
Subject: [PATCH 10/18] add gridplot non square screenshot

---
 examples/desktop/screenshots/gridplot_non_square.png | 3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 examples/desktop/screenshots/gridplot_non_square.png

diff --git a/examples/desktop/screenshots/gridplot_non_square.png b/examples/desktop/screenshots/gridplot_non_square.png
new file mode 100644
index 000000000..7b534aef9
--- /dev/null
+++ b/examples/desktop/screenshots/gridplot_non_square.png
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:abf936904d1b5e2018a72311c510108925f2972dfdf59166580ad27876f9e2be
+size 220140

From fdc17a6880f564af6b2e5d459bdd26be463b65af Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 02:02:06 -0400
Subject: [PATCH 11/18] update CI to use runner with more RAM

---
 .github/workflows/ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7c15e3865..2f1ccd351 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,7 +17,7 @@ jobs:
 
   docs-build:
     name: Docs
-    runs-on: ubuntu-latest
+    runs-on: bigmem
     strategy:
       fail-fast: false
     steps:

From b2250d0a6affcc9675769ec03d39f28898ffd389 Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 02:06:21 -0400
Subject: [PATCH 12/18] update API docs

---
 docs/source/api/graphics/HeatmapGraphic.rst | 2 --
 docs/source/api/layouts/gridplot.rst        | 3 +++
 docs/source/api/layouts/plot.rst            | 3 +++
 docs/source/api/selectors/Synchronizer.rst  | 1 +
 docs/source/api/widgets/ImageWidget.rst     | 2 ++
 5 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/docs/source/api/graphics/HeatmapGraphic.rst b/docs/source/api/graphics/HeatmapGraphic.rst
index 6da6f6531..3bd2f2baa 100644
--- a/docs/source/api/graphics/HeatmapGraphic.rst
+++ b/docs/source/api/graphics/HeatmapGraphic.rst
@@ -26,8 +26,6 @@ Properties
     HeatmapGraphic.position_y
     HeatmapGraphic.position_z
     HeatmapGraphic.visible
-    HeatmapGraphic.vmax
-    HeatmapGraphic.vmin
     HeatmapGraphic.world_object
 
 Methods
diff --git a/docs/source/api/layouts/gridplot.rst b/docs/source/api/layouts/gridplot.rst
index 63f1516cf..b5b03bfa4 100644
--- a/docs/source/api/layouts/gridplot.rst
+++ b/docs/source/api/layouts/gridplot.rst
@@ -22,6 +22,8 @@ Properties
 
     GridPlot.canvas
     GridPlot.renderer
+    GridPlot.toolbar
+    GridPlot.widget
 
 Methods
 ~~~~~~~
@@ -36,4 +38,5 @@ Methods
     GridPlot.remove_animation
     GridPlot.render
     GridPlot.show
+    GridPlot.start_render
 
diff --git a/docs/source/api/layouts/plot.rst b/docs/source/api/layouts/plot.rst
index a0be9287b..bd38720b4 100644
--- a/docs/source/api/layouts/plot.rst
+++ b/docs/source/api/layouts/plot.rst
@@ -31,7 +31,9 @@ Properties
     Plot.renderer
     Plot.scene
     Plot.selectors
+    Plot.toolbar
     Plot.viewport
+    Plot.widget
 
 Methods
 ~~~~~~~
@@ -67,4 +69,5 @@ Methods
     Plot.set_title
     Plot.set_viewport_rect
     Plot.show
+    Plot.start_render
 
diff --git a/docs/source/api/selectors/Synchronizer.rst b/docs/source/api/selectors/Synchronizer.rst
index d0fa0c2a8..2b28fe351 100644
--- a/docs/source/api/selectors/Synchronizer.rst
+++ b/docs/source/api/selectors/Synchronizer.rst
@@ -28,5 +28,6 @@ Methods
     :toctree: Synchronizer_api
 
     Synchronizer.add
+    Synchronizer.clear
     Synchronizer.remove
 
diff --git a/docs/source/api/widgets/ImageWidget.rst b/docs/source/api/widgets/ImageWidget.rst
index 4e779f20b..08bce8d7a 100644
--- a/docs/source/api/widgets/ImageWidget.rst
+++ b/docs/source/api/widgets/ImageWidget.rst
@@ -29,6 +29,7 @@ Properties
     ImageWidget.ndim
     ImageWidget.slider_dims
     ImageWidget.sliders
+    ImageWidget.widget
     ImageWidget.window_funcs
 
 Methods
@@ -38,6 +39,7 @@ Methods
 
     ImageWidget.close
     ImageWidget.reset_vmin_vmax
+    ImageWidget.reset_vmin_vmax_frame
     ImageWidget.set_data
     ImageWidget.show
 

From 2a3dd4ef74979c4f0091b4111105d9d1945a0739 Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 02:18:58 -0400
Subject: [PATCH 13/18] bigmem runner for all jobs

---
 .github/workflows/ci.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2f1ccd351..08a36a971 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -48,7 +48,7 @@ jobs:
 
   test-build-full:
     name: Test examples, env with notebook and glfw
-    runs-on: ubuntu-latest
+    runs-on: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false
@@ -105,7 +105,7 @@ jobs:
 
   test-build-desktop:
     name: Test examples, env with only glfw
-    runs-on: ubuntu-latest
+    runs-on: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false

From 70f7b2e8a491488aad94b75d8b726d728aa5b86f Mon Sep 17 00:00:00 2001
From: kushalkolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 02:22:48 -0400
Subject: [PATCH 14/18] use label in ci

---
 .github/workflows/ci.yml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 08a36a971..9f527facd 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,7 +17,8 @@ jobs:
 
   docs-build:
     name: Docs
-    runs-on: bigmem
+    runs-on:
+      labels: bigmem
     strategy:
       fail-fast: false
     steps:
@@ -48,7 +49,8 @@ jobs:
 
   test-build-full:
     name: Test examples, env with notebook and glfw
-    runs-on: bigmem
+    runs-on:
+      labels: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false
@@ -105,7 +107,8 @@ jobs:
 
   test-build-desktop:
     name: Test examples, env with only glfw
-    runs-on: bigmem
+    runs-on:
+      labels: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false

From 71719a0beb4067e6cc52f83f9e3567a63cf4325a Mon Sep 17 00:00:00 2001
From: Kushal Kolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 02:28:15 -0400
Subject: [PATCH 15/18] Update ci.yml

---
 .github/workflows/ci.yml | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9f527facd..08a36a971 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,8 +17,7 @@ jobs:
 
   docs-build:
     name: Docs
-    runs-on:
-      labels: bigmem
+    runs-on: bigmem
     strategy:
       fail-fast: false
     steps:
@@ -49,8 +48,7 @@ jobs:
 
   test-build-full:
     name: Test examples, env with notebook and glfw
-    runs-on:
-      labels: bigmem
+    runs-on: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false
@@ -107,8 +105,7 @@ jobs:
 
   test-build-desktop:
     name: Test examples, env with only glfw
-    runs-on:
-      labels: bigmem
+    runs-on: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false

From 55936a61477897be886779aafbca3bab736673fb Mon Sep 17 00:00:00 2001
From: Kushal Kolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 02:30:57 -0400
Subject: [PATCH 16/18] Update ci.yml

---
 .github/workflows/ci.yml | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 08a36a971..3226d5424 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,7 +17,9 @@ jobs:
 
   docs-build:
     name: Docs
-    runs-on: bigmem
+    runs-on:
+      group: paid
+      labels: bigmem
     strategy:
       fail-fast: false
     steps:
@@ -48,7 +50,9 @@ jobs:
 
   test-build-full:
     name: Test examples, env with notebook and glfw
-    runs-on: bigmem
+    runs-on:
+      group: paid
+      labels: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false
@@ -105,7 +109,9 @@ jobs:
 
   test-build-desktop:
     name: Test examples, env with only glfw
-    runs-on: bigmem
+    runs-on:
+      group: paid
+      labels: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false

From 0f73d517e93ca5c3e6a3d15bc36ef1dcc1726546 Mon Sep 17 00:00:00 2001
From: Kushal Kolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 02:37:23 -0400
Subject: [PATCH 17/18] Update ci.yml

---
 .github/workflows/ci.yml | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 3226d5424..08a36a971 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,9 +17,7 @@ jobs:
 
   docs-build:
     name: Docs
-    runs-on:
-      group: paid
-      labels: bigmem
+    runs-on: bigmem
     strategy:
       fail-fast: false
     steps:
@@ -50,9 +48,7 @@ jobs:
 
   test-build-full:
     name: Test examples, env with notebook and glfw
-    runs-on:
-      group: paid
-      labels: bigmem
+    runs-on: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false
@@ -109,9 +105,7 @@ jobs:
 
   test-build-desktop:
     name: Test examples, env with only glfw
-    runs-on:
-      group: paid
-      labels: bigmem
+    runs-on: bigmem
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false

From 3d8595483486d247217d777ea976e014baaa649d Mon Sep 17 00:00:00 2001
From: Kushal Kolar <kushalkolar@gmail.com>
Date: Fri, 3 Nov 2023 02:39:42 -0400
Subject: [PATCH 18/18] use regular CI runners, will submit bug report to
 github

---
 .github/workflows/ci.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 08a36a971..7c15e3865 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,7 +17,7 @@ jobs:
 
   docs-build:
     name: Docs
-    runs-on: bigmem
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
     steps:
@@ -48,7 +48,7 @@ jobs:
 
   test-build-full:
     name: Test examples, env with notebook and glfw
-    runs-on: bigmem
+    runs-on: ubuntu-latest
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false
@@ -105,7 +105,7 @@ jobs:
 
   test-build-desktop:
     name: Test examples, env with only glfw
-    runs-on: bigmem
+    runs-on: ubuntu-latest
     if: ${{ !github.event.pull_request.draft }}
     strategy:
       fail-fast: false