Conversation
The native input screen zeroed the input field's start margin, leaving the text 6dp left of the attach and options icons below it, which are centred glyphs inside a 36dp touch target. Restore a 6dp margin so the text sits on the same vertical line as the icon artwork, matching iOS. Co-Authored-By: Claude Opus 5 <[email protected]>
malmstein
marked this pull request as ready for review
September 11, 2026 21:48
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1157893581871903/task/1217495363527447
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
The input screen zeroed the input field's start margin, so the hint and typed text sat 6dp left of the attach and options icons in the row below, which are 20dp glyphs centred in a 36dp touch target. This restores a 6dp start margin on top of the row's 2dp padding, putting the text on the same vertical line as the icon artwork as it is on iOS. The margin is applied in
removeMargins(), which runs fromonAttachedToWindow, so the contextual sheet and edit prompt widgets pick up the same alignment.Steps to test this PR
Input screen alignment
UI changes
Note
Low Risk
Layout-only margin change on the native input widget with no logic, API, or data-handling impact.
Overview
Restores 6dp start margin on the Duck.ai native input field so hint and typed text line up vertically with the bottom-row icon glyphs (attach, options, etc.), matching iOS.
Previously
removeMargins()setmarginStartto 0, which left text ~6dp left of the icons in their 36dp touch targets. The margin now comes from a newnativeInputFieldStartMargindimen and is still applied inremoveMargins()during attach, so the main input screen, contextual sheet, and edit-prompt surfaces share the same alignment.Reviewed by Cursor Bugbot for commit 569f62f. Bugbot is set up for automated code reviews on this repo. Configure here.