Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1203581873609357/task/1213684502971022?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1203581873609357/task/1213689395263676?focus=true
API Proposals URL(s) (if applicable): N/A
Description
Out of scope:
Steps to test this PR
Verify PIR entry point behaves correctly
UI changes
No UI changes
Note
Medium Risk
Changes subscription gating and eligibility semantics for PIR; incorrect precedence could let freemium users run paid work or block subscribers until follow-up run-mode enforcement lands.
Overview
Introduces freemium PIR behind a new internal-default
freemium()remote toggle and aPirFreemiumDataStorethat persists whether the user activated freemium (read path only in this PR; settingdidActivateis deferred).canRunPir()no longer returns a bare enabled/disabled:PirEligibility.Enablednow carriesPirRunMode(SCAN_AND_OPT_OUTfor active PIR subscribers,SCAN_ONLYwhen the freemium flag is on and the user has activated). Paid entitlement is resolved before freemium so subscribers are never downgraded to scan-only. Users without subscription or PIR entitlement can still become eligible via freemium instead of always gettingSUBSCRIPTION_EXPIRED/ENTITLEMENT_LOST.Tests are updated for the new
Enabled(runMode)shape and add coverage for freemium vs subscription precedence.Reviewed by Cursor Bugbot for commit 3866103. Bugbot is set up for automated code reviews on this repo. Configure here.