Skip to content

Expose SocketAsyncEventArgs constructor for suppressing the execution context - #706

Merged
scalablecory merged 3 commits into
dotnet:masterfrom
MarcoRossignoli:exposesaea
Dec 30, 2019
Merged

scalablecory merged 3 commits into
dotnet:masterfrom
MarcoRossignoli:exposesaea

Conversation

@MarcoRossignoli

Copy link
Copy Markdown
Member

@scalablecory scalablecory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@scalablecory

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 10 pipeline(s).

Comment thread src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.cs Outdated
@scalablecory

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 10 pipeline(s).

@davidsh davidsh added this to the 5.0 milestone Dec 9, 2019
@MarcoRossignoli

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 706 in repo dotnet/runtime

@MarcoRossignoli

Copy link
Copy Markdown
Member Author

Commenter does not have sufficient privileges for PR 706 in repo dotnet/runtime

@ViktorHofer @safern is it ok?

@MarcoRossignoli

Copy link
Copy Markdown
Member Author

never mind #718

@davidsh

davidsh commented Dec 10, 2019

Copy link
Copy Markdown
Contributor

/azp run runtime-libraries outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@davidsh

davidsh commented Dec 10, 2019

Copy link
Copy Markdown
Contributor

/azp run runtime-libraries

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@MarcoRossignoli

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 706 in repo dotnet/runtime

@MarcoRossignoli

MarcoRossignoli commented Dec 11, 2019

Copy link
Copy Markdown
Member Author

@davidsh I joined external-ci-access group but seem that it's not retroactive, so for now I cannot re-run ci by myself here.

@safern

safern commented Dec 11, 2019

Copy link
Copy Markdown
Member

/azp run runtime-libraries

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@davidsh

davidsh commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

/azp run runtime-libraries outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants