Add code to flush JSON writer after root-level fast-path serialization - #54502
Merged
Merged
Conversation
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsHelps avoid code patterns like this: aspnet/Benchmarks#1683 (comment).
|
steveharter
approved these changes
Jun 21, 2021
steveharter
left a comment
Contributor
There was a problem hiding this comment.
Makes sense; only source-gen affected; the existing non-sourcegen code already calls Flush() at the end of the root Serialize() method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps avoid code patterns like this: aspnet/Benchmarks#1683 (comment).