Add MailAddress.TryCreate api - #1052
Merged
Merged
Conversation
MarcoRossignoli
commented
Dec 19, 2019
Member
Author
There was a problem hiding this comment.
opted for tuple because is used only inside this class
MarcoRossignoli
commented
Dec 19, 2019
Member
Author
There was a problem hiding this comment.
I've reorganized data to allow reuse and equality with ctors tests.
MarcoRossignoli
commented
Dec 19, 2019
Member
Author
There was a problem hiding this comment.
This is the only place where we need to rely on exception handling.
Member
Author
|
/azp list |
|
Commenter does not have sufficient privileges for PR 1052 in repo dotnet/runtime |
Member
Author
|
/azp list |
|
Commenter does not have sufficient privileges for PR 1052 in repo dotnet/runtime |
Member
|
@ViktorHofer Shouldn't the external-ci group have azp permissions? |
Member
Author
|
just asked #718 (comment) |
Member
|
/azp list |
|
Commenter does not have sufficient privileges for PR 1052 in repo dotnet/runtime |
stephentoub
reviewed
Jan 15, 2020
stephentoub
reviewed
Jan 15, 2020
stephentoub
reviewed
Jan 15, 2020
stephentoub
reviewed
Jan 15, 2020
stephentoub
reviewed
Jan 15, 2020
stephentoub
approved these changes
Jan 15, 2020
stephentoub
left a comment
Member
There was a problem hiding this comment.
Left a few comments, but generally LGTM.
Member
|
@dotnet/ncl, can someone please review? |
ManickaP
reviewed
Jan 22, 2020
Co-Authored-By: Stephen Toub <[email protected]>
Co-Authored-By: Stephen Toub <[email protected]>
Co-Authored-By: Stephen Toub <[email protected]>
davidsh
approved these changes
Feb 10, 2020
davidsh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #907
cc: @scalablecory @davidsh