Skip to content

Inlined GC poll for methods marked with SuppressGCTransitionAttribute #13582

Description

@AaronRobinsonMSFT

The code responsible for creating and inserting GC_Poll instances appears to have degraded since porting over from .NET Framework.

void Compiler::fgCreateGCPolls()

Calling the above function when either GCPOLL_CALL or GCPOLL_INLINE is set results in multiple asserts being fired. This was discovered during the suppress GC work - dotnet/coreclr#26458. The result of this was to manually insert GCPOLL_CALL instances instead of GCPOLL_INLINE.

Additional issues:

/cc @briansull @dotnet/jit-contrib

category:cq
theme:optimization
skill-level:beginner
cost:medium

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMItenet-performancePerformance related issue

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions