Skip to content

Update versions of dependencies - #552

Merged
JoeRobich merged 1 commit into
dotnet:masterfrom
JoeRobich:update-versions
Feb 16, 2020
Merged

JoeRobich merged 1 commit into
dotnet:masterfrom
JoeRobich:update-versions

Conversation

@JoeRobich

Copy link
Copy Markdown
Member

The latest version of System.CommandLine supports loading options via response files. This could be our solution to the request to support a configuration file (#520).

@JoeRobich

Copy link
Copy Markdown
Member Author

@jmarolf PTAL

Comment thread src/Logging/NullScope.cs

namespace Microsoft.CodeAnalysis.Tools.Logging
{
internal class NullScope : IDisposable

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this used for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used by the Loggers. It used to be a public type but has disappeared from the new version of the library.

@jmarolf jmarolf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JoeRobich
JoeRobich merged commit 4b3b782 into dotnet:master Feb 16, 2020
@JoeRobich
JoeRobich deleted the update-versions branch March 5, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants