Conversation
|
Does this change make any measurable performance difference? If we start duplicating the VM code in C# just because we can, it will tun into maintenance nightmare. For now, I would prefer to keep this duplication at minimum and do as needed only if there is a measurable benefit. |
I do not think we want to keep these in a global. Ideally, This should just be |
Yep, these would need to be much more complex, otherwise this will break Samsung folks who stilll use fragile NGen. |
|
@jkotas ok, makes sense, will wait for CI test results just to make sure it works |
Another baby steps towards https://github.com/dotnet/coreclr/issues/18111 (along with #27216)
Ported line by line C++ to C# for these structs (missing some debug asserts,
#if FEATURE_PREJITparts and I don't know to to setg_pEnumClassglobal in order to test if a type is an enum, also I am not sure in the pointer arithmetic e.g. when I doaddr -2).@jkotas I was just learning CoreCLR internals, let me know if it worth continuing or feel free to take over.
But it already works for me, e.g. I can obtain a correct
CorElementTypefor any Array I tried.