Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Replace primitive Array fcalls with managed implementations - #27123

Merged
jkotas merged 2 commits into
dotnet:masterfrom
jkotas:fcalls
Oct 14, 2019
Merged

Replace primitive Array fcalls with managed implementations#27123
jkotas merged 2 commits into
dotnet:masterfrom
jkotas:fcalls

Conversation

@jkotas

@jkotas jkotas commented Oct 10, 2019

Copy link
Copy Markdown
Member

Prep-work for #27106

jkotas
jkotas commented Oct 10, 2019
View reviewed changes
Comment thread src/vm/reflectioninvocation.cpp
@jkotas
jkotas requested a review from VSadov October 10, 2019 06:21
EgorBo
EgorBo reviewed Oct 10, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/src/System/Runtime/CompilerServices/jithelpers.cs
marek-safar
marek-safar reviewed Oct 10, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/RuntimeHelpers.cs Outdated
jkotas
jkotas commented Oct 10, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/RuntimeHelpers.cs Outdated
@jkotas

jkotas commented Oct 11, 2019

Copy link
Copy Markdown
Member Author

/azp run coreclr-ci

@azure-pipelines

azure-pipelines Bot commented Oct 11, 2019

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

jkotas commented Oct 12, 2019

Copy link
Copy Markdown
Member Author

@dotnet/dnceng Many CoreCLR legs are failing Azure DevOps service unavailable errors. Could you please take a look?

error : Request to https://dev.azure.com/dnceng/public/_apis/test/runs?api-version=5.0-preview.2 returned failed status 503 Service Unavailable [/__w/3/s/tests/helixpublishwitharcade.proj]
error :  [/__w/3/s/tests/helixpublishwitharcade.proj]
error : {"$id":"1","innerException":null,"message":"TF10216: Azure DevOps services are currently unavailable. Try again later. Activity Id: 4f1c656e-fbe6-47e4-8eaa-4d5b701cd8dc","typeName":"Microsoft.VisualStudio.Services.CircuitBreaker.CircuitBreakerShortCircuitException, Microsoft.VisualStudio.Services.Common","typeKey":"CircuitBreakerShortCircuitException","errorCode":0,"eventId":3000} [/__w/3/s/tests/helixpublishwitharcade.proj]
error : (NETCORE_ENGINEERING_TELEMETRY=Test) Request to https://dev.azure.com/dnceng/public/_apis/test/runs?api-version=5.0-preview.2 returned failed status 503 Service Unavailable

@stephentoub

stephentoub commented Oct 12, 2019

Copy link
Copy Markdown
Member

corefx CI is also struggling:
dotnet/corefx#41749

@jkotas
jkotas merged commit 4c0b70e into dotnet:master Oct 14, 2019
@filipnavara filipnavara mentioned this pull request Oct 14, 2019
Closed
@ghost

ghost commented Oct 14, 2019 •
edited by ghost
Loading

Copy link
Copy Markdown

/azp run

nvm. Merged.

@jkotas
jkotas deleted the fcalls branch October 27, 2019 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers
@marek-safar marek-safar marek-safar left review comments
@EgorBo EgorBo EgorBo left review comments
@filipnavara filipnavara filipnavara left review comments
@stephentoub stephentoub stephentoub approved these changes
@VSadov VSadov VSadov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jkotas @stephentoub @marek-safar @EgorBo @filipnavara @VSadov