Skip to content

feat: add allow document rejection setting - #3362

Draft
catalinpit wants to merge 4 commits into
mainfrom
feat/org-team-allow-document-rejection-setting
Draft

catalinpit wants to merge 4 commits into
mainfrom
feat/org-team-allow-document-rejection-setting

Conversation

@catalinpit

@catalinpit catalinpit commented Sep 11, 2026

Copy link
Copy Markdown
Member

incomplete

Continues the work from #2641 which only targeted client changes. This PR expands on it:

  • It saves the setting when an organisation or team is updated.
  • Adds support for the mobile menu, V1, and embeds.
  • Lets users override it for each document in the editor.
  • It also checks the setting on the server in rejectDocumentWithToken.

The schema and the logic for determining the setting stay the same as in this PR.

Adds an allowDocumentRejection column to organisation settings (default
true), team settings (nullable, inherits from the organisation) and
document meta (default true), with the migration.

Adds the "Allow Document Rejection" field to the organisation and team
document preferences form, wires it through the settings pages, and lists
it in the reset-to-defaults dialog and the admin settings section. Adds a
per-document Yes/No field to the envelope editor settings dialog.

Exposes the field on the document meta create/update schemas and the
document, envelope, template and editor envelope response schemas, and
hides the reject dialog on the V1 signing page when the document
disallows rejection.
@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
stg-docs Ready Ready Preview Sep 14, 2026 1:48pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
prd-docs Ignored Ignored Sep 14, 2026 1:48pm UTC
prd-openpage-api Ignored Ignored Sep 14, 2026 1:48pm UTC

Request Review

@github-actions github-actions Bot added apps: web Issues related to the webapp 🚨 migrations 🚨 Be advised: PR contains database migrations - Auto-Generated by GitHub Actions on raising a PR labels Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ce3f1b88-8091-4387-b1db-e3eff4f44175

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Accepts allowDocumentRejection in the organisation and team settings
update routes, adds it to the default organisation (true) and team
(inherit) settings, and copies the merged value into the document meta
when a document or template is created via extractDerivedDocumentMeta.
Documents created from a template take the template's value, with an
optional override on envelope.use.

Exposes the field in the recipient signing response and refuses
rejectDocumentWithToken requests for documents that disallow rejection,
since the endpoint can be called directly without the UI.

Extends the document preferences and envelope settings e2e tests to
cover inheritance into the team settings and new documents, and
persistence of the per-document value from the editor.
@vercel
vercel Bot temporarily deployed to Preview – stg-docs September 11, 2026 11:28 Inactive
@github-actions github-actions Bot added the 🚨 e2e changes 🚨 Be advised: PR changes E2E tests - Auto-Generated by GitHub Actions on raising a PR label Sep 11, 2026
@catalinpit catalinpit linked an issue Sep 11, 2026 that may be closed by this pull request
6 tasks
@vercel
vercel Bot temporarily deployed to Preview – stg-docs September 11, 2026 11:46 Inactive
Hides the reject dialog on the V2 signing page sidebar and mobile menu,
the embed V1 signing page and the multi-sign embed view when the
document's allowDocumentRejection is false. In embeds the reject option
is shown only when both the embed's allowDocumentRejection option and
the document setting allow it, and the embed V1 footer layout follows the
same condition. Exposes the field in the multi-sign document response so
the embed view can read it.

Documents the relationship between the embed's allowDocumentRejection
option and the document setting in the iframe and embedded editor docs,
and in the API description of the field.

Part of #2561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apps: web Issues related to the webapp 🚨 e2e changes 🚨 Be advised: PR changes E2E tests - Auto-Generated by GitHub Actions on raising a PR 🚨 migrations 🚨 Be advised: PR contains database migrations - Auto-Generated by GitHub Actions on raising a PR type: documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to disable document rejection per team/organisation

1 participant