Skip to content

fix(i18n): add missing "zu" in German invite/reminder strings - #3331

Open
rzaman8677 wants to merge 1 commit into
documenso:mainfrom
rzaman8677:fix/de-i18n-missing-zu-invite-strings
Open

fix(i18n): add missing "zu" in German invite/reminder strings#3331
rzaman8677 wants to merge 1 commit into
documenso:mainfrom
rzaman8677:fix/de-i18n-missing-zu-invite-strings

Conversation

@rzaman8677

@rzaman8677 rzaman8677 commented Sep 2, 2026

Copy link
Copy Markdown

Summary

  • German requires the infinitive particle "zu" before a bare verb (e.g. "eingeladen, zu unterschreiben" = "invited to sign"). Several msgstr entries in packages/lib/translations/de/web.po dropped it, producing ungrammatical sentences like "hat dich eingeladen, unterschreiben" instead of "hat dich eingeladen, zu unterschreiben".
  • Fixed all 12 affected entries covering signing invitations, resend/reminder emails, and team-invite variants across send-signing-email.handler.ts, resend-document.ts, process-signing-reminder.handler.ts, template-document-invite.tsx, and document-invite.tsx source strings.
  • Verified recipientActionVerb/action resolve to plain lowercased infinitives (e.g. "unterschreiben", "genehmigen") with no "zu" baked in at the source, confirming "zu" was genuinely missing rather than duplicated.
  • Only msgstr values were changed; msgid values are untouched per the translation contribution guide.

Fixes #3283

Test plan

  • Grepped web.po for the eingeladen ... {action} / {recipientActionVerb} pattern before and after to confirm all instances were caught and none were double-fixed.
  • Confirmed via source that the action-verb placeholders are plain infinitives, so "zu + verb" is valid for every recipient role (sign, approve, view, assist).

🤖 Generated with Claude Code

@rzaman8677 @claude
fix(i18n): add missing "zu" in German invite/reminder strings
4e17d20 
German requires the infinitive particle "zu" before a bare verb
(e.g. "eingeladen, zu unterschreiben"). Several msgstr entries in
translations/de/web.po dropped it, producing ungrammatical sentences
like "hat dich eingeladen, unterschreiben" instead of "hat dich
eingeladen, zu unterschreiben".

Fixes documenso#3283

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Copilot AI lite review requested due to automatic review settings September 2, 2026 23:50
@vercel

vercel Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
prd-docs Ignored Ignored Sep 2, 2026 11:50pm UTC
prd-openpage-api Ignored Ignored Sep 2, 2026 11:50pm UTC
stg-docs Skipped Skipped Sep 2, 2026 11:50pm UTC

Request Review

@vercel
vercel Bot temporarily deployed to Preview – stg-docs September 2, 2026 23:50 Inactive
Copilot AI reviewed Sep 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 8bb6c631-e4dc-4af6-8829-3ce0b9f8f828

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mythie

Mythie commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Hey there, it looks like you haven't accepted our contributor license agreement yet. In order for us to accept your pull request we ask that you please fill out the CLA:

https://documen.so/cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[i18n/de] Missing "zu" in signing invitation makes the sentence ungrammatical

3 participants

@rzaman8677 @Mythie