Allow SaveImagesCmd to omit image tags - #2660
Open
HarshDevelops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1872
What was wrong
SaveImagesCmddocuments that an image can be saved without an explicit tag, butwithImage(name, tag)rejected a null tag and always formatted images asname:tag. That made the documented name-only form unusable.What changed
The tag argument is now nullable.
TaggedImage.asString()returns the image name alone when no tag is supplied and keeps the existingname:tagform for tagged images. A small unit test covers both forms without requiring a Docker daemon.Testing
mvn -pl docker-java -Dtest=SaveImagesCmdImplTest testmvn -pl docker-java -Dtest='!OkHttpClientTests' test— 366 tests, 0 failures, 2 skippedmvn -pl docker-java -am checkstyle:checkgit diff --checkThe full reactor test command reaches Docker-dependent transport tests, but no Docker daemon is available in this environment, so that part could not run.