Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Commit 22c8df2

Browse files
samsjasamsja
authored
feat: support python 3.7 (#1055)
* feat: add python 3.7 support Signed-off-by: samsja <[email protected]> * feat: remove get args Signed-off-by: samsja <[email protected]> * fix: fix Signed-off-by: samsja <[email protected]> * fix: fix Signed-off-by: samsja <[email protected]> * chore(ci): bump ci Signed-off-by: samsja <[email protected]> Signed-off-by: samsja <[email protected]>
1 parent ac28cf3 commit 22c8df2

5 files changed

Lines changed: 1239 additions & 1256 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ jobs:
1313
runs-on: ubuntu-latest
1414
steps:
1515
- uses: actions/[email protected]
16-
- name: Set up Python 3.8
16+
- name: Set up Python 3.7
1717
uses: actions/setup-python@v4
1818
with:
19-
python-version: 3.8
19+
python-version: 3.7
2020
- name: Lint with ruff
2121
run: |
2222
python -m pip install --upgrade pip
@@ -32,10 +32,10 @@ jobs:
3232
runs-on: ubuntu-latest
3333
steps:
3434
- uses: actions/[email protected]
35-
- name: Set up Python 3.8
35+
- name: Set up Python 3.7
3636
uses: actions/setup-python@v4
3737
with:
38-
python-version: 3.8
38+
python-version: 3.7
3939
- name: check black
4040
run: |
4141
python -m pip install --upgrade pip
@@ -50,10 +50,10 @@ jobs:
5050
runs-on: ubuntu-latest
5151
steps:
5252
- uses: actions/[email protected]
53-
- name: Set up Python 3.8
53+
- name: Set up Python 3.7
5454
uses: actions/setup-python@v4
5555
with:
56-
python-version: 3.8
56+
python-version: 3.7
5757
- name: Prepare enviroment
5858
run: |
5959
python -m pip install --upgrade pip
@@ -67,10 +67,10 @@ jobs:
6767
runs-on: ubuntu-latest
6868
steps:
6969
- uses: actions/[email protected]
70-
- name: Set up Python 3.8
70+
- name: Set up Python 3.7
7171
uses: actions/setup-python@v4
7272
with:
73-
python-version: 3.8
73+
python-version: 3.7
7474
- name: check mypy
7575
run: |
7676
python -m pip install --upgrade pip
@@ -97,7 +97,7 @@ jobs:
9797
strategy:
9898
fail-fast: false
9999
matrix:
100-
python-version: [3.8]
100+
python-version: [3.7]
101101
# test-path: ${{fromJson(needs.prep-testbed.outputs.matrix)}}
102102
test-path: [tests/integrations, tests/units]
103103
steps:
@@ -126,7 +126,7 @@ jobs:
126126
# files: "coverage.xml"
127127
# - name: Upload coverage from test to Codecov
128128
# uses: codecov/[email protected]
129-
# if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.8'
129+
# if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.7'
130130
# with:
131131
# file: coverage.xml
132132
# flags: ${{ steps.test.outputs.codecov_flag }}

‎.github/workflows/ci_only_pr.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
ref: ${{ env.BRANCH_NAME }}
3838
- uses: actions/setup-python@v4
3939
with:
40-
python-version: 3.8
40+
python-version: 3.7
4141
- uses: actions/setup-node@v2
4242
with:
4343
node-version: '14'

‎docarray/utils/_typing.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
from typing import Any, get_args
1+
from typing import Any
22

3-
from typing_inspect import is_union_type
3+
from typing_inspect import get_args, is_union_type
44

55
from docarray.typing.tensor.abstract_tensor import AbstractTensor
66

0 commit comments

Comments
 (0)