Skip to content

Update default package naming rule according to official style guide. Closes #1429 - #1434

Merged
arturbosch merged 2 commits into
detekt:masterfrom
BoxResin:fix-default-package-naming
Jan 20, 2019
Merged

Update default package naming rule according to official style guide. Closes #1429#1434
arturbosch merged 2 commits into
detekt:masterfrom
BoxResin:fix-default-package-naming

Conversation

@BoxResin

Copy link
Copy Markdown
Contributor

For more information, see this issue

@schalkms

Copy link
Copy Markdown
Member

Thanks for the contribution.
Please run gradle build locally in order to generate the documentation for this rule.
This fixes the build.

@BoxResin

Copy link
Copy Markdown
Contributor Author

@schalkms Thank you! I did it :)

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1434 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1434   +/-   ##
=========================================
  Coverage     74.01%   74.01%           
  Complexity     1896     1896           
=========================================
  Files           326      326           
  Lines          5127     5127           
  Branches        959      959           
=========================================
  Hits           3795     3795           
  Misses          782      782           
  Partials        550      550
Impacted Files Coverage Δ Complexity Δ
...ab/arturbosch/detekt/rules/naming/PackageNaming.kt 100% <100%> (ø) 6 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5b3ec...c11f5c1. Read the comment docs.

@arturbosch
arturbosch merged commit 9c198fe into detekt:master Jan 20, 2019
@arturbosch arturbosch added this to the 1.0.0 milestone Jan 20, 2019
@BoxResin
BoxResin deleted the fix-default-package-naming branch March 20, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants