If present, give URL protocol precedence over other SSL settings - #608
Conversation
|
Looking at the old behavior and this patch, this is what is happening:
The only changed behavior is therefore for I like this addition, as it makes the path to forcing HTTP more clear in my opinion (use As mentioned in #597 - I'm inclined to add a "Disable HTTP"/"Force SSL everywhere" option to allow users to opt out of HTTP all together by either force-upgrading to HTTPS or by logging a warning/error on HTTP. The implication of such an option would be that the user then find any HTTP usage and fix it (Move away from HTTP-only services/providers). |
|
Apparently I'm missing something, as this still does not work for me. Still getting errors that it cannot determine an IP address, even after applying #608
Running manually and via the daemon appears to cause different results, as a manual run prints This is really breaking the functionality of ddclient (which I've used for more than 15 years). Hopefully there's an easy fix (such as switching to a default checkip service which actually works with SSL) I spent the better part of two days trying to resolve this, updating to various versions, applying PRs, and modifying config, and still came up short. |
This is basically a minor adjustment to #482 , updated for the new 3.11 curl-based geturl(). The original PR objections seemed to be focused on lack of time to properly understand the nuances of the old behavior rather than any realistic objection to the only-slightly-different new behavior.
My setup broke for the 3.10 update, with no easy config-only fix (see below). Now Gentoo just updated to 3.11.1, and the 3.10 version of my fix/patch can't be applied, hence this newer patch. This patch doesn't directly restore 3.9, but it is now possible to make a trivial configuration change for situations like this, by just including the protocol as part of each individual broken URL.
Key points:
FUTURE ideas: