fix(elixir-sdk): fix Elixir 1.20 warning - #13677
Open
wingyplus wants to merge 1 commit into
Open
Conversation
Fix the following warning:
```
Compiling 3 files (.ex)
warning: the following clause is redundant:
otherwise ->
previous clauses have already matched on the following types:
:error
nil
where "otherwise" was given the type:
# type: dynamic(:error or nil)
# from: lib/dagger/core/engine_conn.ex:51:7
otherwise
type warning found at:
│
51 │ otherwise -> otherwise
│ ~
│
└─ lib/dagger/core/engine_conn.ex:51:17: Dagger.Core.EngineConn.from_local_cli/1
```
The Elixir type checker warn that the `otherwise` consider as redundant
because `with` clause already covered all the cases.
Signed-off-by: Thanabodee Charoenpiriyakij <[email protected]>
wingyplus
force-pushed
the
fix-elixir-1-20-warning
branch
from
July 18, 2026 00:28
91220f1 to
159e9f3
Compare
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following warning:
The Elixir type checker warn that the
otherwiseconsider as redundant becausewithclause already covered all the cases.