Keep JUnit output when test groups are interleaved - #1894
Open
Angel2Eyes wants to merge 1 commit into
Open
Angel2Eyes wants to merge 1 commit into
Angel2Eyes wants to merge 1 commit into
Conversation
-ojunit rewrote each group file from a single in-memory buffer, so a later visit dropped earlier tests. Keep one bucket per group and snapshot assertion counts when the test ends. Fixes cpputest#1790 Fixes cpputest#1741 Fixes cpputest#168 Fixes cpputest#1207 Co-authored-by: Cursor <[email protected]>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-ojunitoutput so a later visit to the same group no longer truncates earlier tests.assertions=values.Problem
JUnitTestOutputbuffers a single group and openscpputest_<group>.xmlwith mode"w"at every group-end.TestRegistry::endOfGrouptreats a name change as the end of a group, so interleaved tests or-sshuffle causes the reporter to throw away the first visit and overwrite the file with only the last fragment.Problem reported in #1790, #1741, #168, and #1207.
Fix
Keep a linked list of groups (no STL). On each test, append to that group's bucket even if we left it earlier. On group-end, still write the file immediately, but write the full accumulated list. Store the per-test assertion delta at test-end so a rewrite of group A after running group B does not steal B's checks.
Sequential groups produce the same XML shape as before. The JUnit test helper no longer double-runs the last test on a group switch; that only became visible once the reporter stopped wiping the buffer.
Verification
JUnitOutputTestcases still pass, including sequential groups andtestFailuresInSeparateGroups.