Conversation
sylvestre
commented
Apr 3, 2026
Contributor
- tests/ln/non-utf8-src.sh: New test ensuring ln handles source filenames containing non-UTF-8 bytes when linking into a target directory, for both hard links and symbolic links with -t.
- tests/local.mk: Register the new test. ln: accept non-utf8 source names in target-dir modes uutils/coreutils#11403
* tests/ln/non-utf8-src.sh: New test ensuring ln handles source filenames containing non-UTF-8 bytes when linking into a target directory, for both hard links and symbolic links with -t. * tests/local.mk: Register the new test. uutils/coreutils#11403
pixelb
reviewed
Apr 6, 2026
| name=$(printf 'bad_\377') | ||
|
|
||
| # Create source file and target directory. | ||
| touch "$name" || framework_failure_ |
Member
There was a problem hiding this comment.
The bad unicode may not be supported by the file system.
We handle this in tests already like:
echo a > "$(bad_unicode)" \
|| skip_ 'bad unicode not supported in shell or file system'
Member
|
Pushed in 262520980 |
gitmirroring-auto-sync-bot Bot
pushed a commit
to GitMirroring/coreutils
that referenced
this pull request
Apr 6, 2026
* tests/ln/non-utf8-src.sh: New test ensuring ln handles source filenames containing non-UTF-8 bytes when linking into a target directory, for both hard links and symbolic links with -t. * tests/local.mk: Register the new test. uutils/coreutils#11403 coreutils/coreutils#240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.