Skip to content

tests: csplit accepts bad unicode - #187

Closed
oech3 wants to merge 1 commit into
coreutils:masterfrom
oech3:patch-4
Closed

oech3 wants to merge 1 commit into
coreutils:masterfrom
oech3:patch-4

Conversation

@oech3

@oech3 oech3 commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

uutils rejected it

@pixelb

pixelb commented Feb 8, 2026

Copy link
Copy Markdown
Member

printf would be more portable than the echo.

In general it would be good to have one patch to update many utilities to accept bad_unicode, rather than one for each

@oech3

oech3 commented Feb 8, 2026

Copy link
Copy Markdown
Contributor Author

Should I write test/misc/bad-unidocode.sh for 100+ utils at 1 commit?

@oech3
oech3 force-pushed the patch-4 branch 2 times, most recently from 0fe470b to 168e0f0 Compare February 8, 2026 11:44
@oech3
oech3 force-pushed the patch-4 branch 2 times, most recently from e2574cf to 56c7de2 Compare February 8, 2026 11:53
@pixelb

pixelb commented Feb 8, 2026

Copy link
Copy Markdown
Member

Yes this is a better direction thanks.

@oech3

oech3 commented Feb 8, 2026

Copy link
Copy Markdown
Contributor Author

We can move definition of bad_unicode if we moved existing tests too.

@pixelb

pixelb commented Feb 8, 2026

Copy link
Copy Markdown
Member

I'll have a look at using a table driven approach to add more utilities into the mix here

@pixelb pixelb closed this Apr 9, 2026
@oech3
oech3 deleted the patch-4 branch April 10, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants