Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hercules-team/python-augeas
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: certbot/python-augeas
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: certbot-patched
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 2 files changed
  • 2 contributors

Commits on Aug 19, 2020

  1. Hack libaugeas.so.0 path lookup when inside a snap

    Python's cffi module is unable to find libaugeas.so.0 when it is inside
    a snap, so detect this situation and provide the path directly.
    
    See: https://forum.snapcraft.io/t/classic-snaps-and-python/141
    basak authored and bmw committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    fd85b2a View commit details
    Browse the repository at this point in the history
  2. Adjust libaugeas.so.0 path hack for snapcraft

    When running inside snapcraft-the-snap, SNAP is set at snap build time,
    causing this code to run and attempt to find libaugeas.so.0 inside
    snapcraft's own snap. This is incorrect; at build time, we can expect
    libaugeas.so.0 to exist on the build system.
    
    SNAP_NAME should always be set to 'certbot' at runtime, so we can test
    for this to conditionally enable the hack only when required.
    
    This fixes the build when snapcraft is run from inside a snap.
    basak authored and bmw committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    346840a View commit details
    Browse the repository at this point in the history
  3. Update README

    bmw committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a87769e View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Use CERTBOT_AUGEAS_PATH

    bmw committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    8d8c0b3 View commit details
    Browse the repository at this point in the history
Loading