Fix parseDsn() to URL-decode username and password credentials and database name - #19603
Open
webdevsamran wants to merge 1 commit into
Open
webdevsamran wants to merge 1 commit into
webdevsamran wants to merge 1 commit into
Conversation
markstory
reviewed
Aug 28, 2026
Comment on lines
+280
to
+285
| if (isset($parsed['username'])) { | ||
| $parsed['username'] = urldecode($parsed['username']); | ||
| } | ||
| if (isset($parsed['password'])) { | ||
| $parsed['password'] = urldecode($parsed['password']); | ||
| } |
Member
There was a problem hiding this comment.
Shouldn't URL decoding be done on all non-query parts of the DSN? In the doctrine implementation you referenced they decode all components of the URL https://github.com/doctrine/dbal/blob/ff5c1863b4dc16ab900d6552c8401dcf1ae3975f/src/Tools/DsnParser.php#L52-L56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
URL-decodes the \username, \password, and \database\ name parsed from a DSN string in \StaticConfigTrait::parseDsn()\ and \ConnectionManager::parseDsn(). This prevents percent-encoded special characters (such as %21\ for !, %40\ for @, or %23\ for #) in credentials and database names from remaining encoded when establishing database connections.
Fixes #19557