Skip to content

fix default build tags inclusion - #213

Merged
francislavoie merged 1 commit into
masterfrom
fix-tags
Nov 5, 2024
Merged

fix default build tags inclusion#213
francislavoie merged 1 commit into
masterfrom
fix-tags

Conversation

@mohammed90

@mohammed90 mohammed90 commented Nov 5, 2024

Copy link
Copy Markdown
Member

Fixes #212

@mohammed90
fix default build tags inclusion
8c0f223 
Signed-off-by: Mohammed Al Sahaf <[email protected]>
@mohammed90 mohammed90 added the bug Something isn't working label Nov 5, 2024
@mohammed90 mohammed90 mentioned this pull request Nov 5, 2024
Merged
@steffenbusch

steffenbusch commented Nov 5, 2024

Copy link
Copy Markdown

👍 works for me:

go install github.com/caddyserver/xcaddy/cmd/xcaddy@fix-tags
...
2024/11/05 23:23:49 [INFO] exec (timeout=0s): /usr/local/go/bin/go build -o /root/out/caddy_2024-11-05_232157 -ldflags -w -s -trimpath -tags nobadger,nomysql,nopgx
2024/11/05 23:24:44 [INFO] Build complete: /root/out/caddy_2024-11-05_232157
2024/11/05 23:24:44 [INFO] Cleaning up temporary folder: /tmp/buildenv_2024-11-05-2323.1140773682

@francislavoie
francislavoie merged commit c548f44 into master Nov 5, 2024
@mohammed90
mohammed90 deleted the fix-tags branch November 5, 2024 22:42
@dunglas

dunglas commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

Sorry, thanks!

This was referenced Jun 27, 2025
Closed
Closed
@caddyserver caddyserver deleted a comment from SPPRAGUE Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francislavoie francislavoie Awaiting requested review from francislavoie

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error with compiling custom Caddy with version 0.4.3

4 participants

@mohammed90 @steffenbusch @dunglas @francislavoie