add ".exe" when cross compiling for windows - #179
Merged
Merged
Conversation
Member
|
Maybe the condition should only be the target OS? I don't think the platform we're running on matters for the extension (except for choosing the default GOOS I guess). So maybe if the env var is empty it can look at runtime? |
Member
|
@WeidiDeng, is this ready? We need to do a hotfix release, and this is a good change. |
mholt
approved these changes
May 6, 2024
mholt
left a comment
Member
There was a problem hiding this comment.
This LGTM. IMO, we can merge it 🤷♂️
Member
|
Thank you, by the way, @WeidiDeng ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously ".exe" will be added automatically when on windows, but not when cross compiling.