Skip to content

Upgrade from Chromium 153 to Chromium 154 (1.96.x) - #39927

Open
emerick wants to merge 3 commits into
1.96.xfrom
cr154-1.96.x
Open

Upgrade from Chromium 153 to Chromium 154 (1.96.x)#39927
emerick wants to merge 3 commits into
1.96.xfrom
cr154-1.96.x

Conversation

@emerick

@emerick emerick commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@emerick emerick added this to the 1.96.x - Beta milestone Sep 16, 2026
@emerick emerick self-assigned this Sep 16, 2026
@emerick
emerick requested a review from a team as a code owner September 16, 2026 16:18
@github-actions github-actions Bot added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/web3/wallet CI/run-perf-smoke-tests Run smoke performance tests labels Sep 16, 2026
@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

A banned pattern was used.
    browser/ui/brave_browser_browsertest.cc:54:
      Most code should already be scoped to a Browser. Pass in a Browser* or retrieve from an existing entity with a reference to the Browser.

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

A banned pattern was used.
    browser/ui/browser_commands.cc:185:
      Please use `absl::StrFormat` rather.

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

A banned pattern was used.
    browser/ui/webui/welcome_page/brave_welcome_ui.cc:100:
      Most code should already be scoped to a Browser. Pass in a Browser* or retrieve from an existing entity with a reference to the Browser.

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

A banned pattern was used.
    browser/ui/webui/welcome_page/welcome_dom_handler.cc:184:
      Most code should already be scoped to a Browser. Pass in a Browser* or retrieve from an existing entity with a reference to the Browser.

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

chromium_src/ui/views/bubble/bubble_dialog_delegate_view.h: BraveNewsBubbleView forward declaration is no longer needed

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

chromium_src/ui/views/bubble/bubble_dialog_delegate_view.h: BraveHelpBubbleDelegateView forward declaration is no longer needed

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

chromium_src/ui/views/bubble/bubble_dialog_delegate_view.h: WaybackMachineBubbleView forward declaration is no longer needed

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

chromium_src/ui/views/bubble/bubble_dialog_delegate_view.h: PlaylistBubbleView forward declaration is no longer needed

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

chromium_src/ui/views/bubble/bubble_dialog_delegate_view.h: SplitViewMenuBubble forward declaration is no longer needed

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

chromium_src/ui/views/bubble/bubble_dialog_delegate_view.h: SidebarItemAddedFeedbackBubble forward declaration is no longer needed

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

chromium_src/ui/views/bubble/bubble_dialog_delegate_view.h: SidebarEditItemBubbleDelegateView forward declaration is no longer needed

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

chromium_src/ui/views/bubble/bubble_dialog_delegate_view.h: SidebarAddItemBubbleDelegateView forward declaration is no longer needed

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

chromium_src/ui/views/bubble/bubble_dialog_delegate_view.h: BraveBubbleDialogDelegateView forward declaration is no longer needed

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

Do not use "Browser*" type in unittest files (e.g.,
    "*unittest.cc" or "*unittest.h"). Unit tests should generally
    not depend on the full Browser class or related components. Consider
    refactoring to mock dependencies, use test-specific fakes,
    or determine if a browser_test is more appropriate.

Items:

  browser/renderer_context_menu/test/render_view_context_menu_unittest.cc:81:Browser*

@brave-builds

brave-builds commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

Patch should not add or remove empty lines at hunk boundaries

Items:

patches/chrome-browser-resources-settings-search_page-search_page_index.ts.patch:9 (-empty line)
patches/chrome-browser-ui-bookmarks-combined_bookmarks_view_unittest.cc.patch:25 (+empty line)
patches/chrome-browser-ui-browser_window-public-browser_window_features.h.patch:59 (+empty line)
patches/chrome-browser-ui-tabs-tab_strip_model.cc.patch:86 (+empty line)
patches/chrome-browser-ui-tabs-tab_strip_model.h.patch:66 (+empty line)
patches/chrome-browser-ui-unload_controller.h.patch:11 (+empty line)
patches/chrome-browser-ui-unload_controller.h.patch:22 (+empty line)
patches/chrome-browser-ui-views-frame-horizontal_tab_strip_region_view.cc.patch:72 (-empty line)
patches/chrome-browser-ui-views-frame-horizontal_tab_strip_region_view.cc.patch:83 (+empty line)
patches/chrome-browser-ui-views-frame-horizontal_tab_strip_region_view.h.patch:11 (+empty line)
patches/chrome-browser-ui-views-tabs-hovercard-tab_hover_card_bubble_view.h.patch:10 (+empty line)
patches/chrome-browser-ui-views-toolbar-app_menu.h.patch:20 (+empty line)
patches/chrome-browser-ui-views-toolbar-toolbar_view.h.patch:35 (+empty line)
patches/components-autofill-core-browser-ui-autofill_external_delegate.cc.patch:15 (+empty line)
patches/components-gcm_driver-gcm_driver.h.patch:10 (+empty line)
patches/components-sync_device_info-device_info.h.patch:35 (+empty line)
patches/components-sync_device_info-device_info_sync_bridge.cc.patch:39 (+empty line)
patches/components-user_education-views-help_bubble_view.cc.patch:10 (+empty line)
patches/components-variations-variations_seed_store.h.patch:10 (+empty line)
patches/content-browser-devtools-protocol-network_handler.h.patch:12 (+empty line)
patches/content-browser-gpu-gpu_process_host.h.patch:18 (+empty line)
patches/content-browser-service_worker-service_worker_content_settings_proxy_impl.h.patch:11 (+empty line)
patches/content-browser-web_contents-web_contents_impl.h.patch:10 (+empty line)
patches/content-browser-worker_host-shared_worker_content_settings_proxy_impl.h.patch:11 (+empty line)
patches/content-public-browser-navigation_handle.h.patch:9 (+empty line)
patches/third_party-blink-public-web-web_local_frame.h.patch:10 (+empty line)
patches/third_party-blink-renderer-core-frame-web_local_frame_impl.h.patch:18 (+empty line)
patches/third_party-blink-renderer-core-html-canvas-html_canvas_element.h.patch:16 (+empty line)

@emerick
Disable download of "Optimization Guide On Device Models Manifest" co…
912cdb3 
…mponent (#39931)

Upstream replaced the legacy on-device model component (already disabled) with a
new ManifestBroker-based manifest component, which we don't support downloading.
Add its CRX id to the disallowed-components list.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/dc81302c3f2e08d011aadc2f9118107e2547e74a

commit dc81302c3f2e08d011aadc2f9118107e2547e74a
Author: Steven Holte <[email protected]>
Date:   Fri Aug 28 10:59:18 2026 -0700

    [OptimizationGuide] Clean up dead code after ManifestBroker launch

    Remove legacy on-device model execution infrastructure and FakeModelBroker
    that are no longer used following the launch of ManifestBroker.

    This cleans up:
    - Legacy ModelBrokerState and OnDeviceModelComponentStateManager
    - OnDeviceModelComponent, OnDeviceAssetManager, and related loaders
    - Obsolete on-device model component installer logic and prefs
    - Unused on_device_internals WebUI CRX component handlers
    - FakeModelBroker and legacy test harnesses

    Bug: 545726941
    Change-Id: Idded6cc73785064013502d62915243306a6a6964
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8269214
    Reviewed-by: Noah Rose Ledesma <[email protected]>
    Reviewed-by: Evan Liu <[email protected]>
    Commit-Queue: Steven Holte <[email protected]>
    Auto-Submit: Steven Holte <[email protected]>
    Reviewed-by: Mike Dougherty <[email protected]>
    Reviewed-by: Jingyun Liu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#1688156}
@emerick
Fix onboarding crash during import (#39941)
dcfabaa 
We extend the default avatar range to 90 icons (56 Chromium + 34 Brave), but
upstream's `LogProfileAvatar()` only handles indices 0-55, hitting
`NOTREACHED()` whenever a profile's `icon_index` falls in Brave's [56, 90) range
on load. `LogProfileAvatarSelection` was already no-op'd for the same reason;
extend that to `LogProfileAvatarOnLoad`.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/f37ae56ae115ef184ee54e7159aa0fdcac864d13

commit f37ae56ae115ef184ee54e7159aa0fdcac864d13
Author: David Roger <[email protected]>
Date:   Tue Sep 8 14:35:35 2026 -0700

    [M154] [Profiles] Log avatar metric when profile is loaded

    Original change's description:
    > [Profiles] Log avatar metric when profile is loaded
    >
    > Profile.Avatar records avatar selections made during profile creation
    > and in settings, but does not capture the avatar distribution across
    > existing profiles during regular usage.
    >
    > This CL adds Profile.AvatarOnLoad, recorded for regular profiles at
    > profile initialization in ProfileManager::DoFinalInitLogging(). It also
    > updates the summary description for Profile.Avatar in histograms.xml.
    >
    > TAG=agy
    > CONV=8c04dcdc-06ea-40e8-9fb8-e7c168a3dceb
    >
    > Fixed: 555280405
    > Change-Id: Ib4f31b596e9631ebb37293eef1e9ea8be675f41f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8336887
    > Reviewed-by: Ryan Sultanem <[email protected]>
    > Commit-Queue: David Roger <[email protected]>
    > Cr-Commit-Position: refs/heads/main@{#1689807}

    (cherry picked from commit dcedeb7105e26f1c48fa6ea20ca4d44076acb572)

    Bug: 557122049,555280405
    Change-Id: Ib4f31b596e9631ebb37293eef1e9ea8be675f41f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8360157
    Bot-Commit: [email protected] <[email protected]>
    Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: [email protected] <[email protected]>
    Cr-Commit-Position: refs/branch-heads/8037@{#578}
    Cr-Branched-From: e10b20e60f162e7ad88e4930833695a54f4e15fb-refs/heads/main@{#1689415}
@brave-builds

brave-builds commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emerick emerick

Labels

CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-perf-smoke-tests Run smoke performance tests CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet

Projects

None yet

Milestone

1.96.x - Release

Development

Successfully merging this pull request may close these issues.

3 participants

@emerick @brave-builds @cdesouza-chromium