Conversation
Contributor
|
Chromium major version is behind target branch (153.0.8010.37 vs 154.0.8037.41). Please rebase. |
aseren
commented
Sep 16, 2026
| @@ -87,24 +87,13 @@ public class BraveRewards: PreferencesObserver { | |||
| recoverySeedBase64: Data(seed).base64EncodedString() | |||
| ) | |||
| } | |||
| // If ads is already initialized just toggle rewards ads and update the wallet info | |||
| if self.ads.isServiceRunning() { | |||
Collaborator
Author
There was a problem hiding this comment.
This logic is handled in AdsServiceImplIOS now.
…abled The PR changes `Ads Service` on iOS to only run when notification ads or sponsored ads are enabled.
aseren
force-pushed
the
issues/58981
branch
from
September 16, 2026 16:02
207f6c2 to
b94c4da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR changes
Ads Serviceon iOS to only run when notification ads or sponsored ads are enabled.