fix(privacy): Shred private WKWebsiteDataStore data types - #26199
Conversation
| // https://github.com/WebKit/WebKit/blob/b66e4895df40202b14bb20fb47444c3e0a3c164e/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h | ||
| var types = WKWebsiteDataStore.allWebsiteDataTypes() | ||
| types.insert("_WKWebsiteDataTypeHSTSCache") | ||
| types.insert("_WKWebsiteDataTypeMediaKeys") |
There was a problem hiding this comment.
On iOS 17+ this is already included in the allWebsiteDataTypes list, only needs to be added if 17 is not available (relevant info: WebKit/WebKit@560341f, https://developer.apple.com/documentation/webkit/wkwebsitedatatypemediakeys)
| types.insert("_WKWebsiteDataTypeAdClickAttributions") | ||
| types.insert("_WKWebsiteDataTypePrivateClickMeasurements") | ||
| types.insert("_WKWebsiteDataTypeAlternativeServices") | ||
| return types |
There was a problem hiding this comment.
Did you want to also include _WKWebsiteDataTypeFileSystem and _WKWebsiteDataTypeSearchFieldRecentSearches for users not on iOS 17?
There was a problem hiding this comment.
WKWebsiteDataTypeFileSystem is iOS 16+: https://developer.apple.com/documentation/webkit/wkwebsitedatatypefilesystem
I thought WKWebsiteDataTypeSearchFieldRecentSearches was iOS 16+ too, but I'll update to include for iOS 16 users (along with only adding _WKWebsiteDataTypeMediaKeys for iOS 16).
697ace7 to
e6a9f58
Compare
|
Released in v1.73.47 |
WKWebsiteDataStoretypes to Shred.Resolves brave/brave-browser#41863
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: