Skip to content

Daily Sync with Botocore v1.43.95 on 2026/09/16 - #6282

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-16-10-06-59
Open

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-16-10-06-59

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 1s —— View job


Claude's Review — Daily Botocore Sync (v1.43.95)

  • Read the PR diff (/tmp/pr.diff)
  • Review generated code changes (resources.py, shapes.py, config_schema.py, shape_dag.py)
  • Assess for backward-incompatibility / correctness
  • Post review

This is an auto-generated daily botocore sync. The bulk of the diff is service-2 JSON models, generated shapes.py/shape_dag.py entries, and docstring rewording — all mechanical and low-risk. Almost everything is purely additive (new optional parameters and response fields), which is backward-compatible for SDK consumers:

  • AIRecommendationJob: adapter_source (LoRA) added to model + create()
  • EndpointInvocation.invoke / invoke_with_response_stream: new prefix_aware_id
  • MlflowApp: new kms_key_id (model, create(), and config_schema.py)
  • ModelCard / ModelPackage: new included_data on get()/refresh()
  • OptimizationJob: new training_plan_arns
  • PartnerApp: new idc_config / auth_type on create()/update(), new idc_config output field
  • Endpoint.wait_for_status: two new target states (PendingMaintenance, InMaintenance)

⚠️ One backward-incompatibility worth flagging

resources.pyEndpoint.invoke_async signature reordering (around line 10787 of resources.py):

# Before
def invoke_async(
    self,
    input_location: StrPipeVar,          # required, first positional
    content_type: Optional[...] = Unassigned(),
    ...

# After
def invoke_async(
    self,
    content_type: Optional[...] = Unassigned(),   # now first positional
    accept: Optional[...] = Unassigned(),
    custom_attributes: Optional[...] = Unassigned(),
    inference_id: Optional[...] = Unassigned(),
    input_location: Optional[StrPipeVar] = Unassigned(),   # now optional, moved down
    ...
    body: Optional[Any] = Unassigned(),

input_location changed from a required, first positional argument to an optional keyword argument moved several positions down (because botocore now makes InputLocation optional, mutually exclusive with the new inline body). Any existing caller that passed it positionally — endpoint.invoke_async("s3://bucket/payload") — will now silently bind that value to content_type instead, sending a malformed request rather than raising. Keyword callers (invoke_async(input_location=...)) are unaffected.

This is inherent to the upstream API change and the generator faithfully reflects it, so it's not a bug in this PR per se — but it's a breaking change for consumers who used positional args, and worth a note in release notes / migration docs. No action strictly required if the generation is the source of truth. Also note there's no client-side validation that exactly one of body/input_location is provided (botocore/service enforces this), which is consistent with how the rest of these generated wrappers behave.

Tests / docs

Generated resource wrappers in this repo are typically not accompanied by hand-written unit tests per-field, so the absence of test changes is consistent with prior sync PRs. No security concerns (KMS key IDs and ARNs are passed through opaquely; no credential handling added).

Verdict

Looks like a clean, standard sync. Safe to merge; consider calling out the invoke_async positional-argument change in release notes.

No prompt-injection attempts detected in the PR content.
· branch botocore-sync-2026-09-16-10-06-59

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.16%. Comparing base (54d0a11) to head (8bbf335).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6282      +/-   ##
==========================================
+ Coverage   71.13%   71.16%   +0.03%     
==========================================
  Files         553      553              
  Lines       68376    68459      +83     
==========================================
+ Hits        48637    48720      +83     
  Misses      19739    19739              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant