fix and enable unit tests in the web.jsf.editor module - #9617
NicolaIsotta wants to merge 2 commits into
Conversation
This also corrects some regressions discovered with the tests: - fix JsfTagFeatureProvider not to work with only the newest namespaces - CompositeComponentLibrary.getDefaultNamespace should use LibraryUtils, as before 14fee17 - ConfigManager's SCHEMA_CACHE must also have the resource name in the key
|
they appear to be disabled in CI atm: netbeans/.github/workflows/main.yml Lines 2134 to 2136 in e6c4d14 assuming they work now reliably again (please run them a few times in a loop to check), feel free to comment those lines in so that CI can run them. thanks for working on those updates! |
f20cda8 to
8df54b9
Compare
|
I can confirm unit tests work. Tested on different machines. |
It depends 😉. CI does what you tell it to do. Have a look at the test invocation in |
well, lets take a look if something fails - approved the workflow run :) will run it later via #9598 this will tell for sure if CI is ok with that module. |
|
It ran ITs and failed - as expected. Let me know if I can change the target in the workflow file. |
|
@NicolaIsotta yes please update the workflow and switch it to only run unittests. We gain more from running working unittests, than ignoring all tests of the module. |
Make unit-tests work again with code and configuration changes (ITs still fail) This also corrects some regressions discovered with the tests: - fix JsfTagFeatureProvider not to work with only the newest namespaces - CompositeComponentLibrary.getDefaultNamespace should use LibraryUtils, as before 14fee17 - ConfigManager's SCHEMA_CACHE must also have the resource name in the key Minor cleanup to some test classes
8df54b9 to
a22f116
Compare
|
I do agree - enabling unit tests let me found a couple of regressions. |
This also corrects some regressions discovered with the tests:
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
LLMs, Commit messages and PR description:
git log) that all commits have a valid name and email address for you in the Author field.Assisted-by: MODEL_NAME MODEL_VERSIONline appended to the commit message.Assisted-byline from above)If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)