[PHP] keyword return omitted in a constructor override - #9604
Merged
matthiasblaesing merged 1 commit intoSep 15, 2026
Merged
Conversation
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
@DamImpr thanks for the change. To me this makes sense and looking at the PHP documentation the calls to parent are all without return.
One thing needs to change though: we need tests. The PHP Editor module has an exceptional test coverage and we should keep it that way. Please have a look here: matthiasblaesing@36bc8e9. Feel free to squash into your change.
DamImpr
added a commit
to DamImpr/netbeans
that referenced
this pull request
Sep 13, 2026
Add unittest for constructor override fix
… a constructor. Removed the return type from the constructor in the list of methods to override Add unittest for constructor override fix
DamImpr
force-pushed
the
php_construct_without_return
branch
from
September 13, 2026 16:59
414ceaa to
08e48ab
Compare
Contributor
Author
|
@matthiasblaesing Thank you for adding the unit test, i have included it in the PR. |
matthiasblaesing
approved these changes
Sep 13, 2026
Contributor
|
@junichi11 @tmysik this makes sense and i think with the unittest this is good to go. |
tmysik
approved these changes
Sep 15, 2026
tmysik
left a comment
Member
There was a problem hiding this comment.
Agreed, makes sense to me. Thank you for this PR!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In connection with the fix I made in PR 9395, which correctly resolved the issue with the return type in the constructor, IDE still generates
return parent::__construct();when overriding a parent constructor. .Although the return statement in the constructor does not actually cause a runtime error, I’d like to explain why I believe it is still incorrect to include it, and why I am submitting this PR:
The RFC “Ensure correct signatures of magic methods” explicitly states that
This is therefore the officially accepted source which establishes, at the level of the PHP language RFC, the principle that, conceptually, a constructor must not return anything.
Credit for the unit test of this feature: @matthiasblaesing