Remember sort order of the file table in git diff view - #9430

I had a quick look and initially though that it did not work. I opened a testrun with this, changed sorting, closed IDE and reopened. The state was not persistet. Looking at the implementation i then saw that sorting is stored when the diff is closed. This seems counter intuitive. Consider this event order:

1. Open two diffs
2. Change the sort order in the first view
3. Change the sort order in the second view
4. Close the second view
5. Close the first view

I would expect that the last setting survives, but in this case it is the first one.

It is inspired by the same implementation in the subversion module.

Can you point where that can be found? I was not able to find it.

@matthiasblaesing Thanks for your review. I did not realize that this table is used for general git diffs. I wanted mainly sorted files in Git Commit Diff view. Where you can have only one instance of the table.
image

Let me check it and fix it.

Can you point where that can be found? I was not able to find it.

https://github.com/apache/netbeans/blob/master/ide/subversion/src/org/netbeans/modules/subversion/ui/commit/CommitTable.java#L195

@matthiasblaesing Updated. Now it stores on click on the table header, and there is a change in sort order. Storing on a close diff is removed.

Fixed author and commiter name