build: update to angular 22 - #538
Open
samuelmbabhazi wants to merge 6 commits into
Open
samuelmbabhazi wants to merge 6 commits into
samuelmbabhazi wants to merge 6 commits into
Conversation
Angular 22 requires typescript 6, whose defaults enable strict null checks and no implicit any. The library gets real narrowing instead of suppressions and the deprecated baseUrl is replaced by tsconfig-relative paths. ignoreDeprecations stays only for the ts-node bundled in cypress 13, which still registers with moduleResolution node10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the toolchain from Angular 20 to Angular 22.1 (stepping through 21 with its migrations), with ngx-bootstrap 22, ng-packagr 22 and TypeScript 6.
TypeScript 6 turns strict null checks and no implicit any on by default, so the library and demo app are made properly null safe instead of opting out: real narrowing in
SplitGuttersManagerService, overloads ongetPointFromEventso the touch path types its possibleundefined,draggedGutterIndextyped as it is used, andviewChild.requiredwhere the demo templates guarantee presence. The deprecatedbaseUrlis replaced by tsconfig-relativepaths.ignoreDeprecationsremains only for the ts-node bundled in Cypress 13, which still registers withmoduleResolution: node10; it can go once Cypress is upgraded (which #450 will want anyway).The library's
peerDependenciesstay at>=19.0.0and itspackage.jsonversion is untouched, so the release bump stays a maintainer step and published v20 consumers on older Angular are unaffected.CI moves from Node 20/22 to 22/24: Angular 22's engines are
^22.22.3 || ^24.15.0, so the 20.x lane would no longer install.Why
Angular is at 22.1 while the repo toolchain is at 20. #531 (thanks @shlomoa for the groundwork) predates the recent refactors on main (#529, #532) and targets 21, which is already one major behind. This supersedes it with a minimal diff on top of current main: outside the lockfile, 29 files, +141/-88.
Verification
npm run buildgreen (library and app)npm run lintgreennpm installresolves with no peer conflicts