chore(build): remove use of q.denodeify - #6546

This change was triggered by Igor's comment

Why not use https://www.npmjs.com/package/denodeify

Why not use https://www.npmjs.com/package/denodeify

Initially I didn't use denodeify since WebPack has a peculiar way of reporting errors (it doesn't set error arg in a callback, even if there is an error! see: pkozlowski-opensource@c61e207#diff-01f00c1c52bfe3be6b74cb139f885172R22)

But I can see now that denodeify has an option of passing a "filter" function:
https://github.com/matthew-andrews/denodeify#advanced-usage so we could use it, technically speaking. Having said this I'm not sure if it is worth the trouble of adding an additional dependency.

What is your preference?

Aren't there some other places where we use Q.denodeify? If so we should
replace them all with denodeify and drop Q.
On Tue, Jan 19, 2016 at 1:01 AM Pawel Kozlowski [email protected]
wrote:

Why not use https://www.npmjs.com/package/denodeify

Initially I didn't use denodeify since WebPack has a peculiar way of
reporting errors (it doesn't set error arg in a callback, even if there is
an error! see: pkozlowski-opensource/angular@c61e207
#diff-01f00c1c52bfe3be6b74cb139f885172R22
pkozlowski-opensource@c61e207#diff-01f00c1c52bfe3be6b74cb139f885172R22
)

But I can see now that denodeify has an option of passing a "filter"
function:
https://github.com/matthew-andrews/denodeify#advanced-usage so we could
use it, technically speaking. Having said this I'm not sure if it is worth
the trouble of adding an additional dependency.

What is your preference?

—
Reply to this email directly or view it on GitHub
#6546 (comment).

Aren't there some other places where we use Q.denodeify?

Nope, I could find any other uses of Q.denodeify in the angular repo.

@pkozlowski-opensource, can you rebase this? Thanks!

@pkozlowski-opensource could you please rebase ?

@alxhub @vicb rebased & green. Sorry for the delay, it kind of slipped from my radar.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}