Skip to content

chore(CI): add circle CI config - #6520

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:circle
Closed

chore(CI): add circle CI config#6520
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:circle

Conversation

@alexeagle

@alexeagle alexeagle commented Jan 15, 2016

Copy link
Copy Markdown
Contributor

This only runs the JS build (no tests) as an easy place to start.

Green build on my branch: https://circleci.com/gh/alexeagle/angular/5

@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 15, 2016
IgorMinar
IgorMinar reviewed Jan 15, 2016
View reviewed changes
Comment thread .travis.yml Outdated

@IgorMinar IgorMinar Jan 15, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change was already made by @jeffbcross please revert/rebase

@IgorMinar

IgorMinar commented Jan 15, 2016

Copy link
Copy Markdown
Contributor

@alexeagle travis ci failed due to a flake. Isn't it ironic? https://www.youtube.com/watch?v=Jne9t8sHpUc

Let's start a new commit message scope ci. Please use that instead of chore. I've sent a PR to update our contributing.md file: #6521

@IgorMinar IgorMinar added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 15, 2016
@IgorMinar IgorMinar assigned alexeagle and unassigned IgorMinar Jan 15, 2016
@alexeagle
alexeagle force-pushed the circle branch 2 times, most recently from b89a48d to 690e40a Compare January 15, 2016 23:22
@alexeagle alexeagle removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 15, 2016
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Jan 15, 2016
@alexeagle
ci(circle config): add a circle CI config
6efef3e 
This only runs the JS build (no tests) as an easy place to start.

Green build on my branch: https://circleci.com/gh/alexeagle/angular/5

Note, we are just experimenting with Circle at this point...
@mary-poppins

mary-poppins commented Jan 16, 2016

Copy link
Copy Markdown

Merging PR #6520 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-6520.

@jeffbcross jeffbcross assigned jeffbcross and unassigned alexeagle Jan 16, 2016
@mhevery mhevery closed this in 90b3502 Jan 16, 2016
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 7, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexeagle @IgorMinar @mary-poppins @jeffbcross @googlebot