Conversation
|
Either this did not work or we have been running these tests all along: Chrome 39.0.2171 (Linux 0.0.0): Executed 2412 of 2412 SUCCESS (23.502 secs / 22.341 secs)(from https://travis-ci.org/angular/angular/jobs/97037419) Chrome 39.0.2171 (Linux 0.0.0): Executed 2412 of 2412 SUCCESS (25.59 secs / 24.241 secs) |
893d95d to
8ecf34d
Compare
|
These tests are not currently being skipped, but once we upgrade Updated so that these tests are run in separate processes, which prevents our |
|
I'm particularly curious if the additions of Html5LibDomAdapter.makeCurrent();
testSetup();to multi_client_server_message_bus.server.spec.dart and single_client_server_message_bus.server.spec.dart are undesirable for any reason. |
|
This is waiting on #5931 since they touch the same files. |
Widen version dependencies for `package:angular`, `package:code_transformers`, and `package:observe`. `package:guinness` uses `package:unittest` while the newest versions of `package:code_transformers` use `package:test`. This causes our end-to-end Dart transformer tests (which use testing code in `package:code_transformers`) to be skipped. To fix this: - Move e2e tests to run in a separate file - Run `gulp test.server.dart` tests serially Closes angular#5922
|
Merging PR #5935 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-5935. |
|
@kegluneq this is failing when I try to merge to master, even after restarting. Mind taking a look? |
|
@kegluneq sorry, wrong PR |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
A conflict between
package:guinnessandpackage:testis causing ourend-to-end Dart transformer tests to be skipped.
Run these end-to-end tests in a separate file to fix this.
Closes #5934
/cc @kevmoo